Commit 11cda496 authored by Xuezhi Zhang's avatar Xuezhi Zhang Committed by Jani Nikula
Browse files

drm/i915/sysfs: convert snprintf to sysfs_emit 



Fix the following coccicheck warning:
drivers/gpu/drm/i915//i915_sysfs.c:266:8-16:
WARNING: use scnprintf or sprintf
drivers/gpu/drm/i915//i915_sysfs.c:285:8-16:
WARNING: use scnprintf or sprintf
drivers/gpu/drm/i915//i915_sysfs.c:276:8-16:
WARNING: use scnprintf or sprintf
drivers/gpu/drm/i915//i915_sysfs.c:335:8-16:
WARNING: use scnprintf or sprintf
drivers/gpu/drm/i915//i915_sysfs.c:390:8-16:
WARNING: use scnprintf or sprintf
drivers/gpu/drm/i915//i915_sysfs.c:465:8-16:
WARNING: use scnprintf or sprintf
drivers/gpu/drm/i915//i915_sysfs.c:107:8-16:
WARNING: use scnprintf or sprintf
drivers/gpu/drm/i915//i915_sysfs.c:75:8-16:
WARNING: use scnprintf or sprintf
drivers/gpu/drm/i915//i915_sysfs.c:83:8-16:
WARNING: use scnprintf or sprintf
drivers/gpu/drm/i915//i915_sysfs.c:91:8-16:
WARNING: use scnprintf or sprintf
drivers/gpu/drm/i915//i915_sysfs.c:99:8-16:
WARNING: use scnprintf or sprintf
drivers/gpu/drm/i915//i915_sysfs.c:326:8-16:
WARNING: use scnprintf or sprintf

Signed-off-by: default avatarXuezhi Zhang <zhangxuezhi1@yulong.com>
Signed-off-by: default avatarJani Nikula <jani.nikula@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20210404084103.528211-1-llyz108@163.com
parent 2d667442

drivers/gpu/drm/i915/i915_sysfs.c

+12 −18
Original line number Diff line number Diff line
@@ -72,7 +72,7 @@ show_rc6_mask(struct device *kdev, struct device_attribute *attr, char *buf) 
	if (HAS_RC6pp(dev_priv))

		mask |= BIT(2);



	return snprintf(buf, PAGE_SIZE, "%x\n", mask);

	return sysfs_emit(buf, "%x\n", mask);

}



static ssize_t
@@ -80,7 +80,7 @@ show_rc6_ms(struct device *kdev, struct device_attribute *attr, char *buf) 
{

	struct drm_i915_private *dev_priv = kdev_minor_to_i915(kdev);

	u32 rc6_residency = calc_residency(dev_priv, GEN6_GT_GFX_RC6);

	return snprintf(buf, PAGE_SIZE, "%u\n", rc6_residency);

	return sysfs_emit(buf, "%u\n", rc6_residency);

}



static ssize_t
@@ -88,7 +88,7 @@ show_rc6p_ms(struct device *kdev, struct device_attribute *attr, char *buf) 
{

	struct drm_i915_private *dev_priv = kdev_minor_to_i915(kdev);

	u32 rc6p_residency = calc_residency(dev_priv, GEN6_GT_GFX_RC6p);

	return snprintf(buf, PAGE_SIZE, "%u\n", rc6p_residency);

	return sysfs_emit(buf, "%u\n", rc6p_residency);

}



static ssize_t
@@ -96,7 +96,7 @@ show_rc6pp_ms(struct device *kdev, struct device_attribute *attr, char *buf) 
{

	struct drm_i915_private *dev_priv = kdev_minor_to_i915(kdev);

	u32 rc6pp_residency = calc_residency(dev_priv, GEN6_GT_GFX_RC6pp);

	return snprintf(buf, PAGE_SIZE, "%u\n", rc6pp_residency);

	return sysfs_emit(buf, "%u\n", rc6pp_residency);

}



static ssize_t
@@ -104,7 +104,7 @@ show_media_rc6_ms(struct device *kdev, struct device_attribute *attr, char *buf) 
{

	struct drm_i915_private *dev_priv = kdev_minor_to_i915(kdev);

	u32 rc6_residency = calc_residency(dev_priv, VLV_GT_MEDIA_RC6);

	return snprintf(buf, PAGE_SIZE, "%u\n", rc6_residency);

	return sysfs_emit(buf, "%u\n", rc6_residency);

}



static DEVICE_ATTR(rc6_enable, S_IRUGO, show_rc6_mask, NULL);
@@ -263,8 +263,7 @@ static ssize_t gt_act_freq_mhz_show(struct device *kdev, 
	struct drm_i915_private *i915 = kdev_minor_to_i915(kdev);

	struct intel_rps *rps = &i915->gt.rps;



	return snprintf(buf, PAGE_SIZE, "%d\n",

			intel_rps_read_actual_frequency(rps));

	return sysfs_emit(buf, "%d\n", intel_rps_read_actual_frequency(rps));

}



static ssize_t gt_cur_freq_mhz_show(struct device *kdev,
@@ -273,8 +272,7 @@ static ssize_t gt_cur_freq_mhz_show(struct device *kdev, 
	struct drm_i915_private *i915 = kdev_minor_to_i915(kdev);

	struct intel_rps *rps = &i915->gt.rps;



	return snprintf(buf, PAGE_SIZE, "%d\n",

			intel_gpu_freq(rps, rps->cur_freq));

	return sysfs_emit(buf, "%d\n", intel_gpu_freq(rps, rps->cur_freq));

}



static ssize_t gt_boost_freq_mhz_show(struct device *kdev, struct device_attribute *attr, char *buf)
@@ -282,8 +280,7 @@ static ssize_t gt_boost_freq_mhz_show(struct device *kdev, struct device_attribu 
	struct drm_i915_private *i915 = kdev_minor_to_i915(kdev);

	struct intel_rps *rps = &i915->gt.rps;



	return snprintf(buf, PAGE_SIZE, "%d\n",

			intel_gpu_freq(rps, rps->boost_freq));

	return sysfs_emit(buf, "%d\n", intel_gpu_freq(rps, rps->boost_freq));

}



static ssize_t gt_boost_freq_mhz_store(struct device *kdev,
@@ -323,8 +320,7 @@ static ssize_t vlv_rpe_freq_mhz_show(struct device *kdev, 
	struct drm_i915_private *dev_priv = kdev_minor_to_i915(kdev);

	struct intel_rps *rps = &dev_priv->gt.rps;



	return snprintf(buf, PAGE_SIZE, "%d\n",

			intel_gpu_freq(rps, rps->efficient_freq));

	return sysfs_emit(buf, "%d\n", intel_gpu_freq(rps, rps->efficient_freq));

}



static ssize_t gt_max_freq_mhz_show(struct device *kdev, struct device_attribute *attr, char *buf)
@@ -332,8 +328,7 @@ static ssize_t gt_max_freq_mhz_show(struct device *kdev, struct device_attribute 
	struct drm_i915_private *dev_priv = kdev_minor_to_i915(kdev);

	struct intel_rps *rps = &dev_priv->gt.rps;



	return snprintf(buf, PAGE_SIZE, "%d\n",

			intel_gpu_freq(rps, rps->max_freq_softlimit));

	return sysfs_emit(buf, "%d\n", intel_gpu_freq(rps, rps->max_freq_softlimit));

}



static ssize_t gt_max_freq_mhz_store(struct device *kdev,
@@ -387,8 +382,7 @@ static ssize_t gt_min_freq_mhz_show(struct device *kdev, struct device_attribute 
	struct drm_i915_private *dev_priv = kdev_minor_to_i915(kdev);

	struct intel_rps *rps = &dev_priv->gt.rps;



	return snprintf(buf, PAGE_SIZE, "%d\n",

			intel_gpu_freq(rps, rps->min_freq_softlimit));

	return sysfs_emit(buf, "%d\n", intel_gpu_freq(rps, rps->min_freq_softlimit));

}



static ssize_t gt_min_freq_mhz_store(struct device *kdev,
@@ -462,7 +456,7 @@ static ssize_t gt_rp_mhz_show(struct device *kdev, struct device_attribute *attr 
	else

		BUG();



	return snprintf(buf, PAGE_SIZE, "%d\n", val);

	return sysfs_emit(buf, "%d\n", val);

}



static const struct attribute * const gen6_attrs[] = {