Commit 11b45b0b authored Dec 07, 2021 by Lai Jiangshan Committed by Tejun Heo Dec 09, 2021

workqueue: Remove outdated comment about exceptional workers in unbind_workers()



Long time before, workers are not ALL bound after CPU_ONLINE, they can
still be running in other CPUs before self rebinding.

But the commit a9ab775b ("workqueue: directly restore CPU affinity
of workers from CPU_ONLINE") makes rebind_workers() bind them all.

So all workers are on the CPU before the CPU is down.

And the comment in unbind_workers() refers to the workers "which are
still executing works from before the last CPU down" is outdated.
Just removed it.

Signed-off-by: Lai Jiangshan <laijs@linux.alibaba.com>
Signed-off-by: Tejun Heo <tj@kernel.org>

parent 3e5f39ea

kernel/workqueue.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -4978,9 +4978,7 @@ static void unbind_workers(int cpu)
		/*
		* We've blocked all attach/detach operations. Make all workers
		* unbound and set DISASSOCIATED. Before this, all workers
		* except for the ones which are still executing works from
		* before the last CPU down must be on the cpu. After
		* this, they may become diasporas.
		* must be on the cpu. After this, they may become diasporas.
		*/
		for_each_pool_worker(worker, pool)
		worker->flags \|= WORKER_UNBOUND;