Commit 1197eb59 authored by Jeff Layton's avatar Jeff Layton Committed by Chuck Lever
Browse files

lockd: fix nlm_close_files



This loop condition tries a bit too hard to be clever. Just test for
the two indices we care about explicitly.

Cc: J. Bruce Fields <bfields@fieldses.org>
Fixes: 7f024fcd ("Keep read and write fds with each nlm_file")
Signed-off-by: default avatarJeff Layton <jlayton@kernel.org>
Signed-off-by: default avatarChuck Lever <chuck.lever@oracle.com>
parent aec15824
Loading
Loading
Loading
Loading
+4 −5
Original line number Diff line number Diff line
@@ -283,11 +283,10 @@ nlm_file_inuse(struct nlm_file *file)

static void nlm_close_files(struct nlm_file *file)
{
	struct file *f;

	for (f = file->f_file[0]; f <= file->f_file[1]; f++)
		if (f)
			nlmsvc_ops->fclose(f);
	if (file->f_file[O_RDONLY])
		nlmsvc_ops->fclose(file->f_file[O_RDONLY]);
	if (file->f_file[O_WRONLY])
		nlmsvc_ops->fclose(file->f_file[O_WRONLY]);
}

/*