Commit 118c3ba2 authored by Sebastian Andrzej Siewior's avatar Sebastian Andrzej Siewior Committed by Thomas Gleixner
Browse files

gpio: mlxbf2: Use generic_handle_irq_safe() 



On PREEMPT_RT enabled kernels the demultiplex interrupt handler is force
threaded and runs with interrupts enabled. The invocation of
generic_handle_irq() with interrupts enabled triggers a lockdep warning due
to a non-irq safe lock acquisition.

Instead of disabling interrupts on the driver level, use
generic_handle_domain_irq_safe().

[ tglx: Split out from combo patch ]

Signed-off-by: default avatarSebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/r/YnkfWFzvusFFktSt@linutronix.de
parent c6a91405

drivers/gpio/gpio-mlxbf2.c

+2 −4
Original line number Diff line number Diff line
@@ -273,10 +273,8 @@ static irqreturn_t mlxbf2_gpio_irq_handler(int irq, void *ptr) 
	pending = readl(gs->gpio_io + YU_GPIO_CAUSE_OR_CAUSE_EVTEN0);

	writel(pending, gs->gpio_io + YU_GPIO_CAUSE_OR_CLRCAUSE);



	for_each_set_bit(level, &pending, gc->ngpio) {

		int gpio_irq = irq_find_mapping(gc->irq.domain, level);

		generic_handle_irq(gpio_irq);

	}

	for_each_set_bit(level, &pending, gc->ngpio)

		generic_handle_domain_irq_safe(gc->irq.domain, level);



	return IRQ_RETVAL(pending);

}