Commit 1159e25c authored by Prabhakar Kushwaha's avatar Prabhakar Kushwaha Committed by David S. Miller
Browse files

qede: fix crash in rmmod qede while automatic debug collection 



A crash has been observed if rmmod is done while automatic debug
collection in progress. It is due to a race  condition between
both of them.

To fix stop the sp_task during unload to avoid running qede_sp_task
even if they are schedule during removal process.

Signed-off-by: default avatarAlok Prasad <palok@marvell.com>
Signed-off-by: default avatarShai Malin <smalin@marvell.com>
Signed-off-by: default avatarAriel Elior <aelior@marvell.com>
Signed-off-by: default avatarPrabhakar Kushwaha <pkushwaha@marvell.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent c7d10223

drivers/net/ethernet/qlogic/qede/qede.h

+1 −0
Original line number Diff line number Diff line
@@ -501,6 +501,7 @@ struct qede_fastpath { 
#define QEDE_SP_HW_ERR                  4

#define QEDE_SP_ARFS_CONFIG             5

#define QEDE_SP_AER			7

#define QEDE_SP_DISABLE			8



#ifdef CONFIG_RFS_ACCEL

int qede_rx_flow_steer(struct net_device *dev, const struct sk_buff *skb,

drivers/net/ethernet/qlogic/qede/qede_main.c

+8 −0
Original line number Diff line number Diff line
@@ -1009,6 +1009,13 @@ static void qede_sp_task(struct work_struct *work) 
	struct qede_dev *edev = container_of(work, struct qede_dev,

					     sp_task.work);



	/* Disable execution of this deferred work once

	 * qede removal is in progress, this stop any future

	 * scheduling of sp_task.

	 */

	if (test_bit(QEDE_SP_DISABLE, &edev->sp_flags))

		return;



	/* The locking scheme depends on the specific flag:

	 * In case of QEDE_SP_RECOVERY, acquiring the RTNL lock is required to

	 * ensure that ongoing flows are ended and new ones are not started.
@@ -1300,6 +1307,7 @@ static void __qede_remove(struct pci_dev *pdev, enum qede_remove_mode mode) 
	qede_rdma_dev_remove(edev, (mode == QEDE_REMOVE_RECOVERY));



	if (mode != QEDE_REMOVE_RECOVERY) {

		set_bit(QEDE_SP_DISABLE, &edev->sp_flags);

		unregister_netdev(ndev);



		cancel_delayed_work_sync(&edev->sp_task);