Commit 114dda82 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Damien Le Moal
Browse files

ata: sata_gemini: Convert to platform remove callback returning void 



The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new() which already returns void. Eventually after all drivers
are converted, .remove_new() is renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: default avatarDamien Le Moal <dlemoal@kernel.org>
parent 1a9bc02b

drivers/ata/sata_gemini.c

+2 −4
Original line number Diff line number Diff line
@@ -399,7 +399,7 @@ static int gemini_sata_probe(struct platform_device *pdev) 
	return ret;

}



static int gemini_sata_remove(struct platform_device *pdev)

static void gemini_sata_remove(struct platform_device *pdev)

{

	struct sata_gemini *sg = platform_get_drvdata(pdev);
@@ -408,8 +408,6 @@ static int gemini_sata_remove(struct platform_device *pdev) 
		clk_unprepare(sg->sata0_pclk);

	}

	sg_singleton = NULL;



	return 0;

}



static const struct of_device_id gemini_sata_of_match[] = {
@@ -423,7 +421,7 @@ static struct platform_driver gemini_sata_driver = { 
		.of_match_table = gemini_sata_of_match,

	},

	.probe = gemini_sata_probe,

	.remove = gemini_sata_remove,

	.remove_new = gemini_sata_remove,

};

module_platform_driver(gemini_sata_driver);