Commit 10f3b4d7 authored by Ansuel Smith's avatar Ansuel Smith Committed by Miquel Raynal
Browse files

mtd: parsers: qcom: Fix leaking of partition name 



Add cleanup function as the name variable for the partition name was
allocaed but never freed after the use as the add mtd function
duplicate the name and free the pparts struct as the partition name is
assumed to be static.
The leak was found using kmemleak.

Fixes: 803eb124 ("mtd: parsers: Add Qcom SMEM parser")
Signed-off-by: default avatarAnsuel Smith <ansuelsmth@gmail.com>
Reviewed-by: default avatarBjorn Andersson <bjorn.andersson@linaro.org>
Reviewed-by: default avatarManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Signed-off-by: default avatarMiquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/20210525230931.30013-1-ansuelsmth@gmail.com
parent eb1765c4

drivers/mtd/parsers/qcomsmempart.c

+10 −0
Original line number Diff line number Diff line
@@ -159,6 +159,15 @@ static int parse_qcomsmem_part(struct mtd_info *mtd, 
	return ret;

}



static void parse_qcomsmem_cleanup(const struct mtd_partition *pparts,

				   int nr_parts)

{

	int i;



	for (i = 0; i < nr_parts; i++)

		kfree(pparts[i].name);

}



static const struct of_device_id qcomsmem_of_match_table[] = {

	{ .compatible = "qcom,smem-part" },

	{},
@@ -167,6 +176,7 @@ MODULE_DEVICE_TABLE(of, qcomsmem_of_match_table); 


static struct mtd_part_parser mtd_parser_qcomsmem = {

	.parse_fn = parse_qcomsmem_part,

	.cleanup = parse_qcomsmem_cleanup,

	.name = "qcomsmem",

	.of_match_table = qcomsmem_of_match_table,

};