Commit 10e92724 authored by Bjorn Helgaas's avatar Bjorn Helgaas Committed by Rafael J. Wysocki
Browse files

ACPI: Test for ACPI_SUCCESS rather than !ACPI_FAILURE 



The double negative makes it hard to read "if (!ACPI_FAILURE(status))".
Replace it with "if (ACPI_SUCCESS(status))".

Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Acked-by: default avatarGuenter Roeck <linux@roeck-us.net>
Acked-by: default avatarAlex Deucher <alexander.deucher@amd.com>
Acked-by: default avatarTakashi Iwai <tiwai@suse.de>
Acked-by: default avatarMark Brown <broonie@kernel.org>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent 0f39ee83

drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c

+2 −2
Original line number Diff line number Diff line
@@ -291,7 +291,7 @@ static bool amdgpu_atrm_get_bios(struct amdgpu_device *adev) 
			continue;



		status = acpi_get_handle(dhandle, "ATRM", &atrm_handle);

		if (!ACPI_FAILURE(status)) {

		if (ACPI_SUCCESS(status)) {

			found = true;

			break;

		}
@@ -304,7 +304,7 @@ static bool amdgpu_atrm_get_bios(struct amdgpu_device *adev) 
				continue;



			status = acpi_get_handle(dhandle, "ATRM", &atrm_handle);

			if (!ACPI_FAILURE(status)) {

			if (ACPI_SUCCESS(status)) {

				found = true;

				break;

			}

drivers/gpu/drm/radeon/radeon_bios.c

+2 −2
Original line number Diff line number Diff line
@@ -205,7 +205,7 @@ static bool radeon_atrm_get_bios(struct radeon_device *rdev) 
			continue;



		status = acpi_get_handle(dhandle, "ATRM", &atrm_handle);

		if (!ACPI_FAILURE(status)) {

		if (ACPI_SUCCESS(status)) {

			found = true;

			break;

		}
@@ -218,7 +218,7 @@ static bool radeon_atrm_get_bios(struct radeon_device *rdev) 
				continue;



			status = acpi_get_handle(dhandle, "ATRM", &atrm_handle);

			if (!ACPI_FAILURE(status)) {

			if (ACPI_SUCCESS(status)) {

				found = true;

				break;

			}

drivers/hwmon/acpi_power_meter.c

+2 −2
Original line number Diff line number Diff line
@@ -161,7 +161,7 @@ static ssize_t set_avg_interval(struct device *dev, 
	mutex_lock(&resource->lock);

	status = acpi_evaluate_integer(resource->acpi_dev->handle, "_PAI",

				       &args, &data);

	if (!ACPI_FAILURE(status))

	if (ACPI_SUCCESS(status))

		resource->avg_interval = temp;

	mutex_unlock(&resource->lock);
@@ -232,7 +232,7 @@ static ssize_t set_cap(struct device *dev, struct device_attribute *devattr, 
	mutex_lock(&resource->lock);

	status = acpi_evaluate_integer(resource->acpi_dev->handle, "_SHL",

				       &args, &data);

	if (!ACPI_FAILURE(status))

	if (ACPI_SUCCESS(status))

		resource->cap = temp;

	mutex_unlock(&resource->lock);

drivers/platform/x86/asus-laptop.c

+3 −3
Original line number Diff line number Diff line
@@ -861,7 +861,7 @@ static ssize_t infos_show(struct device *dev, struct device_attribute *attr, 
	 * The significance of others is yet to be found.

	 */

	rv = acpi_evaluate_integer(asus->handle, "SFUN", NULL, &temp);

	if (!ACPI_FAILURE(rv))

	if (ACPI_SUCCESS(rv))

		len += sprintf(page + len, "SFUN value         : %#x\n",

			       (uint) temp);

	/*
@@ -873,7 +873,7 @@ static ssize_t infos_show(struct device *dev, struct device_attribute *attr, 
	 * takes several seconds to run on some systems.

	 */

	rv = acpi_evaluate_integer(asus->handle, "HWRS", NULL, &temp);

	if (!ACPI_FAILURE(rv))

	if (ACPI_SUCCESS(rv))

		len += sprintf(page + len, "HWRS value         : %#x\n",

			       (uint) temp);

	/*
@@ -884,7 +884,7 @@ static ssize_t infos_show(struct device *dev, struct device_attribute *attr, 
	 * silently ignored.

	 */

	rv = acpi_evaluate_integer(asus->handle, "ASYM", NULL, &temp);

	if (!ACPI_FAILURE(rv))

	if (ACPI_SUCCESS(rv))

		len += sprintf(page + len, "ASYM value         : %#x\n",

			       (uint) temp);

	if (asus->dsdt_info) {

drivers/spi/spi.c

+1 −1
Original line number Diff line number Diff line
@@ -2210,7 +2210,7 @@ static acpi_status acpi_register_spi_device(struct spi_controller *ctlr, 
		return AE_OK;



	if (!lookup.max_speed_hz &&

	    !ACPI_FAILURE(acpi_get_parent(adev->handle, &parent_handle)) &&

	    ACPI_SUCCESS(acpi_get_parent(adev->handle, &parent_handle)) &&

	    ACPI_HANDLE(ctlr->dev.parent) == parent_handle) {

		/* Apple does not use _CRS but nested devices for SPI slaves */

		acpi_spi_parse_apple_properties(adev, &lookup);