Commit 10debf8c authored by Amjad Ouled-Ameur's avatar Amjad Ouled-Ameur Committed by Daniel Lezcano
Browse files

thermal/drivers/mediatek: Add delay after thermal banks initialization 



Thermal sensor reads performed immediately after thermal bank
initialization returns bogus values. This is currently tackled by returning
0 if the temperature is bogus (exceeding 200000).

Instead, add a delay between the bank init and the thermal zone device
register to properly fix this.

Signed-off-by: default avatarMichael Kao <michael.kao@mediatek.com>
Signed-off-by: default avatarHsin-Yi Wang <hsinyi@chromium.org>
Signed-off-by: default avatarAmjad Ouled-Ameur <aouledameur@baylibre.com>
Reviewed-by: default avatarAngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Link: https://lore.kernel.org/r/20221018-up-i350-thermal-bringup-v9-5-55a1ae14af74@baylibre.com


Signed-off-by: default avatarDaniel Lezcano <daniel.lezcano@linaro.org>
parent 56edffdc

drivers/thermal/mediatek/auxadc_thermal.c

+3 −8
Original line number Diff line number Diff line
@@ -816,14 +816,6 @@ static int mtk_thermal_bank_temperature(struct mtk_thermal_bank *bank) 
			mt, conf->bank_data[bank->id].sensors[i], raw);





		/*

		 * The first read of a sensor often contains very high bogus

		 * temperature value. Filter these out so that the system does

		 * not immediately shut down.

		 */

		if (temp > 200000)

			temp = 0;



		if (temp > max)

			max = temp;

	}
@@ -1281,6 +1273,9 @@ static int mtk_thermal_probe(struct platform_device *pdev) 


	platform_set_drvdata(pdev, mt);



	/* Delay for thermal banks to be ready */

	msleep(30);



	tzdev = devm_thermal_of_zone_register(&pdev->dev, 0, mt,

					      &mtk_thermal_ops);

	if (IS_ERR(tzdev)) {