Commit 10dd83db authored by Wang Wensheng's avatar Wang Wensheng Committed by Jason Gunthorpe
Browse files

RDMA/qedr: Fix error return code in qedr_iw_connect() 

Fix to return a negative error code from the error handling case instead
of 0, as done elsewhere in this function.

Fixes: 82af6d19 ("RDMA/qedr: Fix synchronization methods and memory leaks in qedr")
Link: https://lore.kernel.org/r/20210408113135.92165-1-wangwensheng4@huawei.com


Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Signed-off-by: default avatarWang Wensheng <wangwensheng4@huawei.com>
Acked-by: default avatarMichal <Kalderon&nbsp;&lt;michal.kalderon@marvell.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
parent 26caea5f

drivers/infiniband/hw/qedr/qedr_iw_cm.c

+3 −1
Original line number Diff line number Diff line
@@ -636,8 +636,10 @@ int qedr_iw_connect(struct iw_cm_id *cm_id, struct iw_cm_conn_param *conn_param) 
	memcpy(in_params.local_mac_addr, dev->ndev->dev_addr, ETH_ALEN);



	if (test_and_set_bit(QEDR_IWARP_CM_WAIT_FOR_CONNECT,

			     &qp->iwarp_cm_flags))

			     &qp->iwarp_cm_flags)) {

		rc = -ENODEV;

		goto err; /* QP already being destroyed */

	}



	rc = dev->ops->iwarp_connect(dev->rdma_ctx, &in_params, &out_params);

	if (rc) {