Commit 10d6bdf5 authored by Miaoqian Lin's avatar Miaoqian Lin Committed by Damien Le Moal
Browse files

ata: pata_octeon_cf: Fix refcount leak in octeon_cf_probe 



of_find_device_by_node() takes reference, we should use put_device()
to release it when not need anymore.
Add missing put_device() to avoid refcount leak.

Fixes: 43f01da0 ("MIPS/OCTEON/ata: Convert pata_octeon_cf.c to use device tree.")
Signed-off-by: default avatarMiaoqian Lin <linmq006@gmail.com>
Reviewed-by: default avatarSergey Shtylyov <s.shtylyov@omp.ru>
Signed-off-by: default avatarDamien Le Moal <damien.lemoal@opensource.wdc.com>
parent bf476fe2

drivers/ata/pata_octeon_cf.c

+3 −0
Original line number Diff line number Diff line
@@ -856,12 +856,14 @@ static int octeon_cf_probe(struct platform_device *pdev) 
				int i;

				res_dma = platform_get_resource(dma_dev, IORESOURCE_MEM, 0);

				if (!res_dma) {

					put_device(&dma_dev->dev);

					of_node_put(dma_node);

					return -EINVAL;

				}

				cf_port->dma_base = (u64)devm_ioremap(&pdev->dev, res_dma->start,

									 resource_size(res_dma));

				if (!cf_port->dma_base) {

					put_device(&dma_dev->dev);

					of_node_put(dma_node);

					return -EINVAL;

				}
@@ -871,6 +873,7 @@ static int octeon_cf_probe(struct platform_device *pdev) 
					irq = i;

					irq_handler = octeon_cf_interrupt;

				}

				put_device(&dma_dev->dev);

			}

			of_node_put(dma_node);

		}