Commit 10b0f78a authored by Nathan Chancellor's avatar Nathan Chancellor Committed by Herbert Xu
Browse files

crypto: xor - Remove unused variable count in do_xor_speed 

Clang warns:

crypto/xor.c:101:4: warning: variable 'count' is uninitialized when used
here [-Wuninitialized]
                        count++;
                        ^~~~~
crypto/xor.c:86:17: note: initialize the variable 'count' to silence
this warning
        int i, j, count;
                       ^
                        = 0
1 warning generated.

After the refactoring to use ktime that happened in this function, count
is only assigned, never read. Just remove the variable to get rid of the
warning.

Fixes: c055e3ea ("crypto: xor - use ktime for template benchmarking")
Link: https://github.com/ClangBuiltLinux/linux/issues/1171


Signed-off-by: default avatarNathan Chancellor <natechancellor@gmail.com>
Reviewed-by: default avatarDouglas Anderson <dianders@chromium.org>
Acked-by: default avatarArd Biesheuvel <ardb@kernel.org>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 4f28945d

crypto/xor.c

+1 −3
Original line number Diff line number Diff line
@@ -83,7 +83,7 @@ static void __init 
do_xor_speed(struct xor_block_template *tmpl, void *b1, void *b2)

{

	int speed;

	int i, j, count;

	int i, j;

	ktime_t min, start, diff;



	tmpl->next = template_list;
@@ -98,8 +98,6 @@ do_xor_speed(struct xor_block_template *tmpl, void *b1, void *b2) 
			mb(); /* prevent loop optimzation */

			tmpl->do_2(BENCH_SIZE, b1, b2);

			mb();

			count++;

			mb();

		}

		diff = ktime_sub(ktime_get(), start);

		if (diff < min)