Commit 10930b25 authored Jun 05, 2022 by Darrick J. Wong

xfs: fix variable state usage



The variable @args is fed to a tracepoint, and that's the only place
it's used.  This is fine for the kernel, but for userspace, tracepoints
are #define'd out of existence, which results in this warning on gcc
11.2:

xfs_attr.c: In function ‘xfs_attr_node_try_addname’:
xfs_attr.c:1440:42: warning: unused variable ‘args’ [-Wunused-variable]
 1440 |         struct xfs_da_args              *args = attr->xattri_da_args;
      |                                          ^~~~

Clean this up.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Allison Henderson <allison.henderson@oracle.com>

parent f4288f01

fs/xfs/libxfs/xfs_attr.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -1441,12 +1441,11 @@ static int
		xfs_attr_node_try_addname(
		struct xfs_attr_intent *attr)
		{
		struct xfs_da_args *args = attr->xattri_da_args;
		struct xfs_da_state *state = attr->xattri_da_state;
		struct xfs_da_state_blk *blk;
		int error;

		trace_xfs_attr_node_addname(args);
		trace_xfs_attr_node_addname(state->args);

		blk = &state->path.blk[state->path.active-1];
		ASSERT(blk->magic == XFS_ATTR_LEAF_MAGIC);