Commit 106e0121 authored by Stefan Wahren's avatar Stefan Wahren Committed by Daniel Lezcano
Browse files

thermal/drivers/bcm2711: Don't clamp temperature at zero 



The thermal sensor on BCM2711 is capable of negative temperatures, so don't
clamp the measurements at zero. Since this was the only use for variable t,
drop it.

This change based on a patch by Dom Cobley, who also tested the fix.

Fixes: 59b78135 ("thermal: Add BCM2711 thermal driver")
Signed-off-by: default avatarStefan Wahren <stefan.wahren@i2se.com>
Acked-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
Link: https://lore.kernel.org/r/20220412195423.104511-1-stefan.wahren@i2se.com


Signed-off-by: default avatarDaniel Lezcano <daniel.lezcano@linaro.org>
parent 2caf7396

drivers/thermal/broadcom/bcm2711_thermal.c

+1 −4
Original line number Diff line number Diff line
@@ -38,7 +38,6 @@ static int bcm2711_get_temp(void *data, int *temp) 
	int offset = thermal_zone_get_offset(priv->thermal);

	u32 val;

	int ret;

	long t;



	ret = regmap_read(priv->regmap, AVS_RO_TEMP_STATUS, &val);

	if (ret)
@@ -50,9 +49,7 @@ static int bcm2711_get_temp(void *data, int *temp) 
	val &= AVS_RO_TEMP_STATUS_DATA_MSK;



	/* Convert a HW code to a temperature reading (millidegree celsius) */

	t = slope * val + offset;



	*temp = t < 0 ? 0 : t;

	*temp = slope * val + offset;



	return 0;

}