Commit 1057afa0 authored by Xie Yongji's avatar Xie Yongji Committed by Michael S. Tsirkin
Browse files

vDPA/ifcvf: Fix return value check for vdpa_alloc_device() 



The vdpa_alloc_device() returns an error pointer upon
failure, not NULL. To handle the failure correctly, this
replaces NULL check with IS_ERR() check and propagate the
error upwards.

Fixes: 5a2414bc ("virtio: Intel IFC VF driver for VDPA")
Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarXie Yongji <xieyongji@bytedance.com>
Link: https://lore.kernel.org/r/20210715080026.242-3-xieyongji@bytedance.com


Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
Acked-by: default avatarJason Wang <jasowang@redhat.com>
Reviewed-by: default avatarStefano Garzarella <sgarzare@redhat.com>
parent 9632e78e

drivers/vdpa/ifcvf/ifcvf_main.c

+2 −2
Original line number Diff line number Diff line
@@ -493,9 +493,9 @@ static int ifcvf_probe(struct pci_dev *pdev, const struct pci_device_id *id) 


	adapter = vdpa_alloc_device(struct ifcvf_adapter, vdpa,

				    dev, &ifc_vdpa_ops, NULL);

	if (adapter == NULL) {

	if (IS_ERR(adapter)) {

		IFCVF_ERR(pdev, "Failed to allocate vDPA structure");

		return -ENOMEM;

		return PTR_ERR(adapter);

	}



	pci_set_master(pdev);