Commit 10421247 authored by Wentao_Liang's avatar Wentao_Liang Committed by Jens Axboe
Browse files

drivers:md:fix a potential use-after-free bug 



In line 2884, "raid5_release_stripe(sh);" drops the reference to sh and
may cause sh to be released. However, sh is subsequently used in lines
2886 "if (sh->batch_head && sh != sh->batch_head)". This may result in an
use-after-free bug.

It can be fixed by moving "raid5_release_stripe(sh);" to the bottom of
the function.

Signed-off-by: default avatarWentao_Liang <Wentao_Liang_g@163.com>
Signed-off-by: default avatarSong Liu <song@kernel.org>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 20313b1b

drivers/md/raid5.c

+1 −1
Original line number Diff line number Diff line
@@ -2952,10 +2952,10 @@ static void raid5_end_write_request(struct bio *bi) 
	if (!test_and_clear_bit(R5_DOUBLE_LOCKED, &sh->dev[i].flags))

		clear_bit(R5_LOCKED, &sh->dev[i].flags);

	set_bit(STRIPE_HANDLE, &sh->state);

	raid5_release_stripe(sh);



	if (sh->batch_head && sh != sh->batch_head)

		raid5_release_stripe(sh->batch_head);

	raid5_release_stripe(sh);

}



static void raid5_error(struct mddev *mddev, struct md_rdev *rdev)