Commit 10212754 authored by Hans de Goede's avatar Hans de Goede
Browse files

ACPI: video: Drop NL5x?U, PF4NU1F and PF5?U?? acpi_backlight=native quirks 

acpi_backlight=native is the default for these, but as the comment
explains the quirk was still necessary because even briefly registering
the acpi_video0 backlight; and then unregistering it once the native
driver showed up, was leading to issues.

After the "ACPI: video: Make backlight class device registration
a separate step" patch from earlier in this patch-series, we no
longer briefly register the acpi_video0 backlight on systems where
the native driver should be used.

So this is no longer an issue an the quirks are no longer needed.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=215683


Tested-by: default avatarWerner Sembach <wse@tuxedocomputers.com>
Acked-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
parent de6f3121

drivers/acpi/video_detect.c

+1 −91
Original line number Diff line number Diff line
@@ -609,97 +609,7 @@ static const struct dmi_system_id video_detect_dmi_table[] = { 
		DMI_MATCH(DMI_BOARD_NAME, "N250P"),

		},

	},

	/*

	 * Clevo NL5xRU and NL5xNU/TUXEDO Aura 15 Gen1 and Gen2 have both a

	 * working native and video interface. However the default detection

	 * mechanism first registers the video interface before unregistering

	 * it again and switching to the native interface during boot. This

	 * results in a dangling SBIOS request for backlight change for some

	 * reason, causing the backlight to switch to ~2% once per boot on the

	 * first power cord connect or disconnect event. Setting the native

	 * interface explicitly circumvents this buggy behaviour, by avoiding

	 * the unregistering process.

	 */

	{

	.callback = video_detect_force_native,

	.ident = "Clevo NL5xRU",

	.matches = {

		DMI_MATCH(DMI_BOARD_NAME, "NL5xRU"),

		},

	},

	{

	.callback = video_detect_force_native,

	.ident = "Clevo NL5xRU",

	.matches = {

		DMI_MATCH(DMI_SYS_VENDOR, "TUXEDO"),

		DMI_MATCH(DMI_BOARD_NAME, "AURA1501"),

		},

	},

	{

	.callback = video_detect_force_native,

	.ident = "Clevo NL5xRU",

	.matches = {

		DMI_MATCH(DMI_SYS_VENDOR, "TUXEDO"),

		DMI_MATCH(DMI_BOARD_NAME, "EDUBOOK1502"),

		},

	},

	{

	.callback = video_detect_force_native,

	.ident = "Clevo NL5xNU",

	.matches = {

		DMI_MATCH(DMI_BOARD_NAME, "NL5xNU"),

		},

	},

	/*

	 * The TongFang PF5PU1G, PF4NU1F, PF5NU1G, and PF5LUXG/TUXEDO BA15 Gen10,

	 * Pulse 14/15 Gen1, and Pulse 15 Gen2 have the same problem as the Clevo

	 * NL5xRU and NL5xNU/TUXEDO Aura 15 Gen1 and Gen2. See the description

	 * above.

	 */

	{

	.callback = video_detect_force_native,

	.ident = "TongFang PF5PU1G",

	.matches = {

		DMI_MATCH(DMI_BOARD_NAME, "PF5PU1G"),

		},

	},

	{

	.callback = video_detect_force_native,

	.ident = "TongFang PF4NU1F",

	.matches = {

		DMI_MATCH(DMI_BOARD_NAME, "PF4NU1F"),

		},

	},

	{

	.callback = video_detect_force_native,

	.ident = "TongFang PF4NU1F",

	.matches = {

		DMI_MATCH(DMI_SYS_VENDOR, "TUXEDO"),

		DMI_MATCH(DMI_BOARD_NAME, "PULSE1401"),

		},

	},

	{

	.callback = video_detect_force_native,

	.ident = "TongFang PF5NU1G",

	.matches = {

		DMI_MATCH(DMI_BOARD_NAME, "PF5NU1G"),

		},

	},

	{

	.callback = video_detect_force_native,

	.ident = "TongFang PF5NU1G",

	.matches = {

		DMI_MATCH(DMI_SYS_VENDOR, "TUXEDO"),

		DMI_MATCH(DMI_BOARD_NAME, "PULSE1501"),

		},

	},

	{

	.callback = video_detect_force_native,

	.ident = "TongFang PF5LUXG",

	.matches = {

		DMI_MATCH(DMI_BOARD_NAME, "PF5LUXG"),

		},

	},



	/*

	 * Desktops which falsely report a backlight and which our heuristics

	 * for this do not catch.