Commit 0ff9bf9f authored by Colin Ian King's avatar Colin Ian King Committed by Thomas Zimmermann
Browse files

drm: simpledrm: Fix use after free issues 



There are two occurrances where objects are being free'd via
a put call and yet they are being referenced after this. Fix these
by adding in the missing continue statement so that the put on the
end of the loop is skipped over.

Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Signed-off-by: default avatarThomas Zimmermann <tzimmermann@suse.de>
Addresses-Coverity: ("Use after free")
Fixes: 11e8f5fd ("drm: Add simpledrm driver")
Link: https://patchwork.freedesktop.org/patch/msgid/20210512203051.299026-1-colin.king@canonical.com
parent 858aa5a4

drivers/gpu/drm/tiny/simpledrm.c

+2 −0
Original line number Diff line number Diff line
@@ -298,6 +298,7 @@ static int simpledrm_device_init_clocks(struct simpledrm_device *sdev) 
			drm_err(dev, "failed to enable clock %u: %d\n",

				i, ret);

			clk_put(clock);

			continue;

		}

		sdev->clks[i] = clock;

	}
@@ -415,6 +416,7 @@ static int simpledrm_device_init_regulators(struct simpledrm_device *sdev) 
			drm_err(dev, "failed to enable regulator %u: %d\n",

				i, ret);

			regulator_put(regulator);

			continue;

		}



		sdev->regulators[i++] = regulator;