Commit 0fec5180 authored by Douglas Anderson's avatar Douglas Anderson Committed by Greg Kroah-Hartman
Browse files

tty: serial: qcom-geni-serial: Fix %lu -> %u in print statements 



When we multiply an unsigned int by a u32 we still end up with an
unsigned int. That means we should specify "%u" not "%lu" in the
format code.

NOTE: this fix was chosen instead of somehow promoting the value to
"unsigned long" since the max baud rate from the earlier call to
uart_get_baud_rate() is 4000000 and the max sampling rate is 32.
4000000 * 32 = 0x07a12000, not even close to overflowing 32-bits.

Fixes: c474c775 ("tty: serial: qcom-geni-serial: Fix get_clk_div_rate() which otherwise could return a sub-optimal clock rate.")
Reported-by: default avatarMark Brown <broonie@kernel.org>
Signed-off-by: default avatarDouglas Anderson <dianders@chromium.org>
Link: https://lore.kernel.org/r/20220802132250.1.Iea061e14157a17e114dbe2eca764568a02d6b889@changeid


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 014482b6

drivers/tty/serial/qcom_geni_serial.c

+2 −2
Original line number Diff line number Diff line
@@ -1033,12 +1033,12 @@ static void qcom_geni_serial_set_termios(struct uart_port *uport, 
		sampling_rate, &clk_div);

	if (!clk_rate) {

		dev_err(port->se.dev,

			"Couldn't find suitable clock rate for %lu\n",

			"Couldn't find suitable clock rate for %u\n",

			baud * sampling_rate);

		goto out_restart_rx;

	}



	dev_dbg(port->se.dev, "desired_rate-%lu, clk_rate-%lu, clk_div-%u\n",

	dev_dbg(port->se.dev, "desired_rate-%u, clk_rate-%lu, clk_div-%u\n",

			baud * sampling_rate, clk_rate, clk_div);



	uport->uartclk = clk_rate;