Commit 0feb3429 authored by Bart Van Assche's avatar Bart Van Assche Committed by Martin K. Petersen
Browse files

scsi: fas216: Introduce the function fas216_queue_command_internal() 

This patch does not change any functionality but prepares for removal of
the second argument of the fas216_queue_command_lck() function.

Link: https://lore.kernel.org/r/20211007204618.2196847-13-bvanassche@acm.org


Signed-off-by: default avatarBart Van Assche <bvanassche@acm.org>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 814818fd

drivers/scsi/arm/fas216.c

+10 −4
Original line number Diff line number Diff line
@@ -2184,7 +2184,7 @@ static void fas216_done(FAS216_Info *info, unsigned int result) 
}



/**

 * fas216_queue_command - queue a command for adapter to process.

 * fas216_queue_command_internal - queue a command for the adapter to process

 * @SCpnt: Command to queue

 * @done: done function to call once command is complete

 *
@@ -2192,7 +2192,7 @@ static void fas216_done(FAS216_Info *info, unsigned int result) 
 * Returns: 0 on success, else error.

 * Notes: io_request_lock is held, interrupts are disabled.

 */

static int fas216_queue_command_lck(struct scsi_cmnd *SCpnt,

static int fas216_queue_command_internal(struct scsi_cmnd *SCpnt,

					 void (*done)(struct scsi_cmnd *))

{

	FAS216_Info *info = (FAS216_Info *)SCpnt->device->host->hostdata;
@@ -2233,6 +2233,12 @@ static int fas216_queue_command_lck(struct scsi_cmnd *SCpnt, 
	return result;

}



static int fas216_queue_command_lck(struct scsi_cmnd *SCpnt,

				    void (*done)(struct scsi_cmnd *))

{

	return fas216_queue_command_internal(SCpnt, done);

}



DEF_SCSI_QCMD(fas216_queue_command)



/**
@@ -2272,7 +2278,7 @@ static int fas216_noqueue_command_lck(struct scsi_cmnd *SCpnt, 
	BUG_ON(info->scsi.irq);



	info->internal_done = 0;

	fas216_queue_command_lck(SCpnt, fas216_internal_done);

	fas216_queue_command_internal(SCpnt, fas216_internal_done);



	/*

	 * This wastes time, since we can't return until the command is