Commit 0f8bf018 authored Apr 13, 2022 by Maciej Fijalkowski Committed by Daniel Borkmann Apr 15, 2022

ixgbe, xsk: Diversify return values from xsk_wakeup call paths



Currently, when debugging AF_XDP workloads, one can correlate the -ENXIO
return code as the case that XSK is not in the bound state. Returning
same code from ndo_xsk_wakeup can be misleading and simply makes it
harder to follow what is going on.

Change ENXIOs in ixgbe's ndo_xsk_wakeup() implementation to EINVALs, so
that when probing it is clear that something is wrong on the driver
side, not the xsk_{recv,send}msg.

There is a -ENETDOWN that can happen from both kernel/driver sides
though, but I don't have a correct replacement for this on one of the
sides, so let's keep it that way.

Signed-off-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Link: https://lore.kernel.org/bpf/20220413153015.453864-11-maciej.fijalkowski@intel.com

parent ed7ae2d6

drivers/net/ethernet/intel/ixgbe/ixgbe_xsk.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -526,10 +526,10 @@ int ixgbe_xsk_wakeup(struct net_device *dev, u32 qid, u32 flags)
		return -ENETDOWN;

		if (!READ_ONCE(adapter->xdp_prog))
		return -ENXIO;
		return -EINVAL;

		if (qid >= adapter->num_xdp_queues)
		return -ENXIO;
		return -EINVAL;

		ring = adapter->xdp_ring[qid];

		@@ -537,7 +537,7 @@ int ixgbe_xsk_wakeup(struct net_device *dev, u32 qid, u32 flags)
		return -ENETDOWN;

		if (!ring->xsk_pool)
		return -ENXIO;
		return -EINVAL;

		if (!napi_if_scheduled_mark_missed(&ring->q_vector->napi)) {
		u64 eics = BIT_ULL(ring->q_vector->v_idx);