Commit 0f597ed4 authored by Saeed Mahameed's avatar Saeed Mahameed
Browse files

net/mlx5: EQ, Introduce atomic notifier chain subscription API 



Use atomic_notifier_chain to fire firmware events at internal mlx5 core
components such as eswitch/fpga/clock/FW tracer/etc.., this is to
avoid explicit calls from low level mlx5_core to upper components and to
simplify the mlx5_core API for future developments.

Simply provide register/unregister notifiers API and call the notifier
chain on firmware async events.

Example: to subscribe to a FW event:
struct mlx5_nb port_event;

MLX5_NB_INIT(&port_event, port_event_handler, PORT_CHANGE);
mlx5_eq_notifier_register(mdev, &port_event);

where:
 - port_event_handler is the notifier block callback.
 - PORT_EVENT is the suffix of MLX5_EVENT_TYPE_PORT_CHANGE.

The above will guarantee that port_event_handler will receive all FW
events of the type MLX5_EVENT_TYPE_PORT_CHANGE.

To receive all FW/HW events one can subscribe to
MLX5_EVENT_TYPE_NOTIFY_ANY.

The next few patches will start moving all mlx5 core components to use
this new API and cleanup mlx5_eq_async_int misx handler from component
explicit calls and specific logic.

Signed-off-by: default avatarSaeed Mahameed <saeedm@mellanox.com>
parent 6d2d6fc8

drivers/net/ethernet/mellanox/mlx5/core/eq.c

+39 −3
Original line number Diff line number Diff line
@@ -31,6 +31,7 @@ 
 */



#include <linux/interrupt.h>

#include <linux/notifier.h>

#include <linux/module.h>

#include <linux/mlx5/driver.h>

#include <linux/mlx5/eq.h>
@@ -68,8 +69,10 @@ struct mlx5_irq_info { 
struct mlx5_eq_table {

	struct list_head        comp_eqs_list;

	struct mlx5_eq          pages_eq;

	struct mlx5_eq          async_eq;

	struct mlx5_eq	        cmd_eq;

	struct mlx5_eq          async_eq;



	struct atomic_notifier_head nh[MLX5_EVENT_TYPE_MAX];



	struct mutex            lock; /* sync async eqs creations */

	int			num_comp_vectors;
@@ -316,13 +319,17 @@ u32 mlx5_eq_poll_irq_disabled(struct mlx5_eq_comp *eq) 
static irqreturn_t mlx5_eq_async_int(int irq, void *eq_ptr)

{

	struct mlx5_eq *eq = eq_ptr;

	struct mlx5_core_dev *dev = eq->dev;

	struct mlx5_eq_table *eqt;

	struct mlx5_core_dev *dev;

	struct mlx5_eqe *eqe;

	int set_ci = 0;

	u32 cqn = -1;

	u32 rsn;

	u8 port;



	dev = eq->dev;

	eqt = dev->priv.eq_table;



	while ((eqe = next_eqe_sw(eq))) {

		/*

		 * Make sure we read EQ entry contents after we've
@@ -437,6 +444,13 @@ static irqreturn_t mlx5_eq_async_int(int irq, void *eq_ptr) 
			break;

		}



		if (likely(eqe->type < MLX5_EVENT_TYPE_MAX))

			atomic_notifier_call_chain(&eqt->nh[eqe->type], eqe->type, eqe);

		else

			mlx5_core_warn_once(dev, "notifier_call_chain is not setup for eqe: %d\n", eqe->type);



		atomic_notifier_call_chain(&eqt->nh[MLX5_EVENT_TYPE_NOTIFY_ANY], eqe->type, eqe);



		++eq->cons_index;

		++set_ci;
@@ -625,7 +639,7 @@ int mlx5_eq_del_cq(struct mlx5_eq *eq, struct mlx5_core_cq *cq) 
int mlx5_eq_table_init(struct mlx5_core_dev *dev)

{

	struct mlx5_eq_table *eq_table;

	int err;

	int i, err;



	eq_table = kvzalloc(sizeof(*eq_table), GFP_KERNEL);

	if (!eq_table)
@@ -638,6 +652,8 @@ int mlx5_eq_table_init(struct mlx5_core_dev *dev) 
		goto kvfree_eq_table;



	mutex_init(&eq_table->lock);

	for (i = 0; i < MLX5_EVENT_TYPE_MAX; i++)

		ATOMIC_INIT_NOTIFIER_HEAD(&eq_table->nh[i]);



	return 0;
@@ -1202,3 +1218,23 @@ void mlx5_eq_table_destroy(struct mlx5_core_dev *dev) 
	destroy_async_eqs(dev);

	free_irq_vectors(dev);

}



int mlx5_eq_notifier_register(struct mlx5_core_dev *dev, struct mlx5_nb *nb)

{

	struct mlx5_eq_table *eqt = dev->priv.eq_table;



	if (nb->event_type >= MLX5_EVENT_TYPE_MAX)

		return -EINVAL;



	return atomic_notifier_chain_register(&eqt->nh[nb->event_type], &nb->nb);

}



int mlx5_eq_notifier_unregister(struct mlx5_core_dev *dev, struct mlx5_nb *nb)

{

	struct mlx5_eq_table *eqt = dev->priv.eq_table;



	if (nb->event_type >= MLX5_EVENT_TYPE_MAX)

		return -EINVAL;



	return atomic_notifier_chain_unregister(&eqt->nh[nb->event_type], &nb->nb);

}

drivers/net/ethernet/mellanox/mlx5/core/lib/eq.h

+5 −0
Original line number Diff line number Diff line
@@ -4,6 +4,8 @@ 
#ifndef __LIB_MLX5_EQ_H__

#define __LIB_MLX5_EQ_H__

#include <linux/mlx5/driver.h>

#include <linux/mlx5/eq.h>

#include <linux/mlx5/cq.h>



#define MLX5_MAX_IRQ_NAME   (32)

#define MLX5_EQE_SIZE       (sizeof(struct mlx5_eqe))
@@ -90,4 +92,7 @@ void mlx5_core_eq_free_irqs(struct mlx5_core_dev *dev); 
struct cpu_rmap *mlx5_eq_table_get_rmap(struct mlx5_core_dev *dev);

#endif



int mlx5_eq_notifier_register(struct mlx5_core_dev *dev, struct mlx5_nb *nb);

int mlx5_eq_notifier_unregister(struct mlx5_core_dev *dev, struct mlx5_nb *nb);



#endif

drivers/net/ethernet/mellanox/mlx5/core/mlx5_core.h

+5 −0
Original line number Diff line number Diff line
@@ -78,6 +78,11 @@ do { \ 
		 __func__, __LINE__, current->pid,			\

		##__VA_ARGS__)



#define mlx5_core_warn_once(__dev, format, ...)				\

	dev_warn_once(&(__dev)->pdev->dev, "%s:%d:(pid %d): " format,	\

		      __func__, __LINE__, current->pid,			\

		      ##__VA_ARGS__)



#define mlx5_core_info(__dev, format, ...)				\

	dev_info(&(__dev)->pdev->dev, format, ##__VA_ARGS__)

include/linux/mlx5/device.h

+9 −1
Original line number Diff line number Diff line
@@ -301,9 +301,15 @@ enum { 
	MLX5_EVENT_QUEUE_TYPE_DCT = 6,

};



/* mlx5 components can subscribe to any one of these events via

 * mlx5_eq_notifier_register API.

 */

enum mlx5_event {

	/* Special value to subscribe to any event */

	MLX5_EVENT_TYPE_NOTIFY_ANY	   = 0x0,

	/* HW events enum start: comp events are not subscribable */

	MLX5_EVENT_TYPE_COMP		   = 0x0,



	/* HW Async events enum start: subscribable events */

	MLX5_EVENT_TYPE_PATH_MIG	   = 0x01,

	MLX5_EVENT_TYPE_COMM_EST	   = 0x02,

	MLX5_EVENT_TYPE_SQ_DRAINED	   = 0x03,
@@ -341,6 +347,8 @@ enum mlx5_event { 
	MLX5_EVENT_TYPE_FPGA_QP_ERROR      = 0x21,



	MLX5_EVENT_TYPE_DEVICE_TRACER      = 0x26,



	MLX5_EVENT_TYPE_MAX                = MLX5_EVENT_TYPE_DEVICE_TRACER + 1,

};



enum {

include/linux/mlx5/eq.h

+14 −2
Original line number Diff line number Diff line
@@ -4,8 +4,6 @@ 
#ifndef MLX5_CORE_EQ_H

#define MLX5_CORE_EQ_H



#include <linux/mlx5/driver.h>



enum {

	MLX5_EQ_PAGEREQ_IDX        = 0,

	MLX5_EQ_CMD_IDX            = 1,
@@ -22,6 +20,7 @@ enum { 
#define MLX5_NUM_SPARE_EQE (0x80)



struct mlx5_eq;

struct mlx5_core_dev;



struct mlx5_eq_param {

	u8             index;
@@ -57,4 +56,17 @@ static inline u32 mlx5_eq_update_cc(struct mlx5_eq *eq, u32 cc) 
	return cc;

}



struct mlx5_nb {

	struct notifier_block nb;

	u8 event_type;

};



#define mlx5_nb_cof(ptr, type, member) \

	(container_of(container_of(ptr, struct mlx5_nb, nb), type, member))



#define MLX5_NB_INIT(name, handler, event) do {              \

	(name)->nb.notifier_call = handler;                  \

	(name)->event_type = MLX5_EVENT_TYPE_##event;        \

} while (0)



#endif /* MLX5_CORE_EQ_H */