Commit 0f392c95 authored by Jason A. Donenfeld's avatar Jason A. Donenfeld
Browse files

m68k: use fallback for random_get_entropy() instead of zero



In the event that random_get_entropy() can't access a cycle counter or
similar, falling back to returning 0 is really not the best we can do.
Instead, at least calling random_get_entropy_fallback() would be
preferable, because that always needs to return _something_, even
falling back to jiffies eventually. It's not as though
random_get_entropy_fallback() is super high precision or guaranteed to
be entropic, but basically anything that's not zero all the time is
better than returning zero all the time.

Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Arnd Bergmann <arnd@arndb.de>
Acked-by: default avatarGeert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: default avatarJason A. Donenfeld <Jason@zx2c4.com>
parent 1366992e
Loading
Loading
Loading
Loading
+1 −1
Original line number Original line Diff line number Diff line
@@ -35,7 +35,7 @@ static inline unsigned long random_get_entropy(void)
{
{
	if (mach_random_get_entropy)
	if (mach_random_get_entropy)
		return mach_random_get_entropy();
		return mach_random_get_entropy();
	return 0;
	return random_get_entropy_fallback();
}
}
#define random_get_entropy	random_get_entropy
#define random_get_entropy	random_get_entropy