Commit 0f0aa848 authored by Petr Mladek's avatar Petr Mladek
Browse files

printk/index: Fix warning about missing prototypes 



The commit 33701557 ("printk: Userspace format indexing support")
triggered the following build failure:

kernel/printk/index.c:140:6: warning: no previous prototype for ‘pi_create_file’ [-Wmissing-prototypes]
 void pi_create_file(struct module *mod)
      ^~~~~~~~~~~~~~
kernel/printk/index.c:146:6: warning: no previous prototype for ‘pi_remove_file’ [-Wmissing-prototypes]
 void pi_remove_file(struct module *mod)
      ^~~~~~~~~~~~~~

Fixes: 33701557 ("printk: Userspace format indexing support")
Reported-by: default avatarkernel test robot <lkp@intel.com>
Suggested-by: default avatarChris Down <chris@chrisdown.name>
[pmladek@suse.com: Let the compiler decide about inlining.]
Signed-off-by: default avatarPetr Mladek <pmladek@suse.com>
Link: https://lore.kernel.org/lkml/YPql089IwSpudw%2F1@alley/
parent 86ce91d5

kernel/printk/index.c

+2 −2
Original line number Diff line number Diff line
@@ -137,13 +137,13 @@ static const char *pi_get_module_name(struct module *mod) 
}

#endif



void pi_create_file(struct module *mod)

static void pi_create_file(struct module *mod)

{

	debugfs_create_file(pi_get_module_name(mod), 0444, dfs_index,

				       mod, &dfs_index_fops);

}



void pi_remove_file(struct module *mod)

static void pi_remove_file(struct module *mod)

{

	debugfs_remove(debugfs_lookup(pi_get_module_name(mod), dfs_index));

}