Commit 0f00e70e authored by Jakub Kicinski's avatar Jakub Kicinski Committed by David S. Miller
Browse files

batman-adv: use eth_hw_addr_set() instead of ether_addr_copy() 



Commit 406f42fa ("net-next: When a bond have a massive amount
of VLANs...") introduced a rbtree for faster Ethernet address look
up. To maintain netdev->dev_addr in this tree we need to make all
the writes to it got through appropriate helpers.

Convert batman from ether_addr_copy() to eth_hw_addr_set():

  @@
  expression dev, np;
  @@
  - ether_addr_copy(dev->dev_addr, np)
  + eth_hw_addr_set(dev, np)

Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
Acked-by: default avatarSven Eckelmann <sven@narfation.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 08bb7516

net/batman-adv/soft-interface.c

+1 −1
Original line number Diff line number Diff line
@@ -134,7 +134,7 @@ static int batadv_interface_set_mac_addr(struct net_device *dev, void *p) 
		return -EADDRNOTAVAIL;



	ether_addr_copy(old_addr, dev->dev_addr);

	ether_addr_copy(dev->dev_addr, addr->sa_data);

	eth_hw_addr_set(dev, addr->sa_data);



	/* only modify transtable if it has been initialized before */

	if (atomic_read(&bat_priv->mesh_state) != BATADV_MESH_ACTIVE)