Commit 0efd5a47 authored Mar 07, 2024 by Colin Ian King Committed by sanglipeng1 Aug 23, 2024

usb: sl811-hcd: only defined function checkdone if QUIRK2 is defined

stable inclusion
from stable-v5.10.215
commit e9efe31e6baf82e8d159e34e01e6f94584ef1d96
category: bugfix
bugzilla: https://gitee.com/openeuler/kernel/issues/IAJJ2D

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=e9efe31e6baf82e8d159e34e01e6f94584ef1d96



--------------------------------

[ Upstream commit 12f371e2b6cb4b79c788f1f073992e115f4ca918 ]

Function checkdone is only required if QUIRK2 is defined, so add
appropriate #if / #endif around the function.

Cleans up clang scan build warning:
drivers/usb/host/sl811-hcd.c:588:18: warning: unused function
'checkdone' [-Wunused-function]

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Link: https://lore.kernel.org/r/20240307111351.1982382-1-colin.i.king@gmail.com


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: sanglipeng1 <sanglipeng1@jd.com>

parent 06ea9623

drivers/usb/host/sl811-hcd.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -585,6 +585,7 @@ done(struct sl811 sl811, struct sl811h_ep ep, u8 bank)
		finish_request(sl811, ep, urb, urbstat);
		}

		#ifdef QUIRK2
		static inline u8 checkdone(struct sl811 *sl811)
		{
		u8 ctl;
		@@ -616,6 +617,7 @@ static inline u8 checkdone(struct sl811 *sl811)
		#endif
		return irqstat;
		}
		#endif

		static irqreturn_t sl811h_irq(struct usb_hcd *hcd)
		{