Commit 0ee66ddc authored by Harshad Shirwadkar's avatar Harshad Shirwadkar Committed by Theodore Ts'o
Browse files

jbd2: don't touch buffer state until it is filled 



Fast commit buffers should be filled in before toucing their
state. Remove code that sets buffer state as dirty before the buffer
is passed to the file system.

Suggested-by: default avatarJan Kara <jack@suse.cz>
Signed-off-by: default avatarHarshad Shirwadkar <harshadshirwadkar@gmail.com>
Link: https://lore.kernel.org/r/20201106035911.1942128-12-harshadshirwadkar@gmail.com


Signed-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
parent cc80586a

fs/jbd2/journal.c

+0 −4
Original line number Diff line number Diff line
@@ -891,11 +891,7 @@ int jbd2_fc_get_buf(journal_t *journal, struct buffer_head **bh_out) 
	if (!bh)

		return -ENOMEM;



	lock_buffer(bh);



	clear_buffer_uptodate(bh);

	set_buffer_dirty(bh);

	unlock_buffer(bh);

	journal->j_fc_wbuf[fc_off] = bh;



	*bh_out = bh;