Commit 0ed96051 authored by Eric Dumazet's avatar Eric Dumazet Committed by Peter Zijlstra
Browse files

rseq: Remove redundant access_ok() 



After commit 8f281770 ("rseq: Use get_user/put_user rather
than __get_user/__put_user") we no longer need
an access_ok() call from __rseq_handle_notify_resume()

Mathieu pointed out the same cleanup can be done
in rseq_syscall().

Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: default avatarMathieu Desnoyers <mathieu.desnoyers@efficios.com>
Link: https://lkml.kernel.org/r/20210413203352.71350-3-eric.dumazet@gmail.com
parent 60af388d

kernel/rseq.c

+1 −4
Original line number Diff line number Diff line
@@ -273,8 +273,6 @@ void __rseq_handle_notify_resume(struct ksignal *ksig, struct pt_regs *regs) 


	if (unlikely(t->flags & PF_EXITING))

		return;

	if (unlikely(!access_ok(t->rseq, sizeof(*t->rseq))))

		goto error;

	ret = rseq_ip_fixup(regs);

	if (unlikely(ret < 0))

		goto error;
@@ -301,8 +299,7 @@ void rseq_syscall(struct pt_regs *regs) 


	if (!t->rseq)

		return;

	if (!access_ok(t->rseq, sizeof(*t->rseq)) ||

	    rseq_get_rseq_cs(t, &rseq_cs) || in_rseq_cs(ip, &rseq_cs))

	if (rseq_get_rseq_cs(t, &rseq_cs) || in_rseq_cs(ip, &rseq_cs))

		force_sig(SIGSEGV);

}