Commit 0ed48061 authored by Zhang Yi's avatar Zhang Yi Committed by Andrew Morton
Browse files

isofs: replace ll_rw_block() 

ll_rw_block() is not safe for the sync read path because it cannot
guarantee that submitting read IO if the buffer has been locked. We
could get false positive EIO return from zisofs_uncompress_block() if
he buffer has been locked by others. So stop using ll_rw_block(),
switch to sync helper instead.

Link: https://lkml.kernel.org/r/20220901133505.2510834-6-yi.zhang@huawei.com


Signed-off-by: default avatarZhang Yi <yi.zhang@huawei.com>
Reviewed-by: default avatarJan Kara <jack@suse.cz>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent 86a020cc

fs/isofs/compress.c

+1 −1
Original line number Diff line number Diff line
@@ -82,7 +82,7 @@ static loff_t zisofs_uncompress_block(struct inode *inode, loff_t block_start, 
		return 0;

	}

	haveblocks = isofs_get_blocks(inode, blocknum, bhs, needblocks);

	ll_rw_block(REQ_OP_READ, haveblocks, bhs);

	bh_read_batch(haveblocks, bhs);



	curbh = 0;

	curpage = 0;