Unverified Commit 0ecb0018 authored by openeuler-ci-bot's avatar openeuler-ci-bot Committed by Gitee
Browse files

!6961 [sync] PR-6861: media: dvb-frontends: avoid stack overflow warnings with clang 

Merge Pull Request from: @openeuler-sync-bot 
 

Origin pull request: 
https://gitee.com/openeuler/kernel/pulls/6861 
 
PR sync from: Cai Xinchen <caixinchen1@huawei.com>
https://mailweb.openeuler.org/hyperkitty/list/kernel@openeuler.org/message/D6IY5NENRELQHB2VVM7EQAIL4NWY7KML/ 
 
https://gitee.com/src-openeuler/kernel/issues/I9L9J6 
 
Link:https://gitee.com/openeuler/kernel/pulls/6961

 

Reviewed-by: default avatarJialin Zhang <zhangjialin11@huawei.com>
Signed-off-by: default avatarJialin Zhang <zhangjialin11@huawei.com>
parents eac4ffd2 899c3038

drivers/media/dvb-frontends/stv0367.c

+8 −26
Original line number Diff line number Diff line
@@ -118,50 +118,32 @@ static const s32 stv0367cab_RF_LookUp2[RF_LOOKUP_TABLE2_SIZE][RF_LOOKUP_TABLE2_S 
	}

};



static

int stv0367_writeregs(struct stv0367_state *state, u16 reg, u8 *data, int len)

static noinline_for_stack

int stv0367_writereg(struct stv0367_state *state, u16 reg, u8 data)

{

	u8 buf[MAX_XFER_SIZE];

	u8 buf[3] = { MSB(reg), LSB(reg), data };

	struct i2c_msg msg = {

		.addr = state->config->demod_address,

		.flags = 0,

		.buf = buf,

		.len = len + 2

		.len = 3,

	};

	int ret;



	if (2 + len > sizeof(buf)) {

		printk(KERN_WARNING

		       "%s: i2c wr reg=%04x: len=%d is too big!\n",

		       KBUILD_MODNAME, reg, len);

		return -EINVAL;

	}





	buf[0] = MSB(reg);

	buf[1] = LSB(reg);

	memcpy(buf + 2, data, len);



	if (i2cdebug)

		printk(KERN_DEBUG "%s: [%02x] %02x: %02x\n", __func__,

			state->config->demod_address, reg, buf[2]);

			state->config->demod_address, reg, data);



	ret = i2c_transfer(state->i2c, &msg, 1);

	if (ret != 1)

		printk(KERN_ERR "%s: i2c write error! ([%02x] %02x: %02x)\n",

			__func__, state->config->demod_address, reg, buf[2]);

			__func__, state->config->demod_address, reg, data);



	return (ret != 1) ? -EREMOTEIO : 0;

}



static int stv0367_writereg(struct stv0367_state *state, u16 reg, u8 data)

{

	u8 tmp = data; /* see gcc.gnu.org/bugzilla/show_bug.cgi?id=81715 */



	return stv0367_writeregs(state, reg, &tmp, 1);

}



static u8 stv0367_readreg(struct stv0367_state *state, u16 reg)

static noinline_for_stack

u8 stv0367_readreg(struct stv0367_state *state, u16 reg)

{

	u8 b0[] = { 0, 0 };

	u8 b1[] = { 0 };