Commit 0e959b4e authored by Vidya Srinivas's avatar Vidya Srinivas Committed by Ville Syrjälä
Browse files

drm/i915: Add PLANE_CUS_CTL restriction in max_width 



PLANE_CUS_CTL has a restriction of 4096 width even though
PLANE_SIZE and scaler size registers supports max 5120.
Take care of this restriction in max_width.

Without this patch, when 5k content is sent on HDR plane
with NV12 content, FIFO underrun is seen and screen blanks
out.

v2: Addressed review comments from Ville. Added separate
functions for max_width - for HDR and SDR

v3: Addressed review comments from Ville. Changed names of
HDR and SDR max_width functions to icl_hdr_plane_max_width
and icl_sdr_plane_max_width

v4: Fixed paranthesis alignment. No code change

Reviewed-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: default avatarVidya Srinivas <vidya.srinivas@intel.com>
[vsyrjala: Fix alignment]
Signed-off-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20211202110836.17536-1-vidya.srinivas@intel.com
parent f35ed346

drivers/gpu/drm/i915/display/skl_universal_plane.c

+17 −4
Original line number Diff line number Diff line
@@ -420,7 +420,17 @@ static int icl_plane_min_width(const struct drm_framebuffer *fb, 
	}

}



static int icl_plane_max_width(const struct drm_framebuffer *fb,

static int icl_hdr_plane_max_width(const struct drm_framebuffer *fb,

				   int color_plane,

				   unsigned int rotation)

{

	if (intel_format_info_is_yuv_semiplanar(fb->format, fb->modifier))

		return 4096;

	else

		return 5120;

}



static int icl_sdr_plane_max_width(const struct drm_framebuffer *fb,

				   int color_plane,

				   unsigned int rotation)

{
@@ -2108,7 +2118,10 @@ skl_universal_plane_create(struct drm_i915_private *dev_priv, 


	if (DISPLAY_VER(dev_priv) >= 11) {

		plane->min_width = icl_plane_min_width;

		plane->max_width = icl_plane_max_width;

		if (icl_is_hdr_plane(dev_priv, plane_id))

			plane->max_width = icl_hdr_plane_max_width;

		else

			plane->max_width = icl_sdr_plane_max_width;

		plane->max_height = icl_plane_max_height;

		plane->min_cdclk = icl_plane_min_cdclk;

	} else if (DISPLAY_VER(dev_priv) >= 10) {