Commit 0e900029 authored by Michal Orzel's avatar Michal Orzel Committed by Andrew Morton
Browse files

ipc/sem: remove redundant assignments 

Get rid of redundant assignments which end up in values not being
read either because they are overwritten or the function ends.

Reported by clang-tidy [deadcode.DeadStores]

Link: https://lkml.kernel.org/r/20220409101933.207157-1-michalorzel.eng@gmail.com


Signed-off-by: default avatarMichal Orzel <michalorzel.eng@gmail.com>
Reviewed-by: default avatarTom Rix <trix@redhat.com>
Reviewed-by: default avatarNathan Chancellor <nathan@kernel.org>
Cc: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent 800c24dc

ipc/sem.c

+0 −2
Original line number Diff line number Diff line
@@ -766,7 +766,6 @@ static int perform_atomic_semop(struct sem_array *sma, struct sem_queue *q) 
	for (sop = sops; sop < sops + nsops; sop++) {

		curr = &sma->sems[sop->sem_num];

		sem_op = sop->sem_op;

		result = curr->semval;



		if (sop->sem_flg & SEM_UNDO) {

			int undo = un->semadj[sop->sem_num] - sem_op;
@@ -1430,7 +1429,6 @@ static int semctl_main(struct ipc_namespace *ns, int semid, int semnum, 
	if (err)

		goto out_rcu_wakeup;



	err = -EACCES;

	switch (cmd) {

	case GETALL:

	{