Commit 0e7c353e authored by Colin Ian King's avatar Colin Ian King Committed by Martin K. Petersen
Browse files

scsi: pm80xx: fix logic to break out of loop when register value is 2 or 3 

The condition (reg_val != 2) || (reg_val != 3) will always be true because
reg_val cannot be equal to two different values at the same time. Fix this
by replacing the || operator with && so that the loop will loop if reg_val
is not a 2 and not a 3 as was originally intended.

Fixes: 50dc2f221455 ("scsi: pm80xx: Modified the logic to collect fatal dump")
Link: https://lore.kernel.org/r/20191120135031.270708-1-colin.king@canonical.com


Addresses-Coverity: ("Constant expression result")
Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Acked-by: default avatarJack Wang <jinpu.wang@cloud.ionos.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 82ea3e0e

drivers/scsi/pm8001/pm80xx_hwi.c

+1 −1
Original line number Diff line number Diff line
@@ -348,7 +348,7 @@ ssize_t pm80xx_get_fatal_dump(struct device *cdev, 
			do {

				reg_val = pm8001_mr32(fatal_table_address,

					MPI_FATAL_EDUMP_TABLE_STATUS);

			} while (((reg_val != 2) || (reg_val != 3)) &&

			} while (((reg_val != 2) && (reg_val != 3)) &&

					time_before(jiffies, start));



			if (reg_val < 2) {