Commit 0e2c8e6d authored by Lin Yujun's avatar Lin Yujun Committed by Daniel Lezcano
Browse files

clocksource/drivers/timer-gxp: Add missing error handling in gxp_timer_probe 



Add platform_device_put() to make sure to free the platform
device in the event platform_device_add() fails.

Fixes: 5184f4bf ("clocksource/drivers/timer-gxp: Add HPE GXP Timer")
Signed-off-by: default avatarLin Yujun <linyujun809@huawei.com>
Link: https://lore.kernel.org/r/20220914033018.97484-1-linyujun809@huawei.com


Signed-off-by: default avatarDaniel Lezcano <daniel.lezcano@linaro.org>
parent 6c3b62d9

drivers/clocksource/timer-gxp.c

+6 −1
Original line number Diff line number Diff line
@@ -171,6 +171,7 @@ static int gxp_timer_probe(struct platform_device *pdev) 
{

	struct platform_device *gxp_watchdog_device;

	struct device *dev = &pdev->dev;

	int ret;



	if (!gxp_timer) {

		pr_err("Gxp Timer not initialized, cannot create watchdog");
@@ -187,7 +188,11 @@ static int gxp_timer_probe(struct platform_device *pdev) 
	gxp_watchdog_device->dev.platform_data = gxp_timer->counter;

	gxp_watchdog_device->dev.parent = dev;



	return platform_device_add(gxp_watchdog_device);

	ret = platform_device_add(gxp_watchdog_device);

	if (ret)

		platform_device_put(gxp_watchdog_device);



	return ret;

}



static const struct of_device_id gxp_timer_of_match[] = {