Commit 0e22bfb7 authored by Parav Pandit's avatar Parav Pandit Committed by Saeed Mahameed
Browse files

net/mlx5e: E-switch, Fix rate calculation for overflow 



rate_bytes_ps is a 64-bit field. It passed as 32-bit field to
apply_police_params(). Due to this when police rate is higher
than 4Gbps, 32-bit calculation ignores the carry. This results
in incorrect rate configurationn the device.

Fix it by performing 64-bit calculation.

Fixes: fcb64c0f ("net/mlx5: E-Switch, add ingress rate support")
Signed-off-by: default avatarParav Pandit <parav@nvidia.com>
Reviewed-by: default avatarEli Cohen <elic@nvidia.com>
Signed-off-by: default avatarSaeed Mahameed <saeedm@nvidia.com>
parent 9c899aa6

drivers/net/ethernet/mellanox/mlx5/core/en_tc.c

+1 −1
Original line number Diff line number Diff line
@@ -5040,7 +5040,7 @@ static int apply_police_params(struct mlx5e_priv *priv, u64 rate, 
	 */

	if (rate) {

		rate = (rate * BITS_PER_BYTE) + 500000;

		rate_mbps = max_t(u32, do_div(rate, 1000000), 1);

		rate_mbps = max_t(u64, do_div(rate, 1000000), 1);

	}



	err = mlx5_esw_modify_vport_rate(esw, vport_num, rate_mbps);