Commit 0e0fd557 authored by Miaoqian Lin's avatar Miaoqian Lin Committed by Greg Kroah-Hartman
Browse files

serial: 8250_aspeed_vuart: Fix potential NULL dereference in aspeed_vuart_probe 



platform_get_resource() may fail and return NULL, so we should
better check it's return value to avoid a NULL pointer dereference.

Fixes: 54da3e38 ("serial: 8250_aspeed_vuart: use UPF_IOREMAP to set up register mapping")
Signed-off-by: default avatarMiaoqian Lin <linmq006@gmail.com>
Link: https://lore.kernel.org/r/20220404143842.16960-1-linmq006@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 60efd051

drivers/tty/serial/8250/8250_aspeed_vuart.c

+2 −0
Original line number Diff line number Diff line
@@ -429,6 +429,8 @@ static int aspeed_vuart_probe(struct platform_device *pdev) 
	timer_setup(&vuart->unthrottle_timer, aspeed_vuart_unthrottle_exp, 0);



	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);

	if (!res)

		return -EINVAL;



	memset(&port, 0, sizeof(port));

	port.port.private_data = vuart;