Commit 0e02a53d authored by Guojia Liao's avatar Guojia Liao Committed by David S. Miller
Browse files

net: hns3: optimized MAC address in management table. 



mac_addr_hi32 and mac_addr_lo16 are used to store the MAC address
for management table. But using array of mac_addr[ETH_ALEN] would
be more general and not need to care about the big-endian mode of
the CPU.

Signed-off-by: default avatarGuojia Liao <liaoguojia@huawei.com>
Signed-off-by: default avatarHuazhong Tan <tanhuazhong@huawei.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 5f06b903

drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.h

+2 −2
Original line number Diff line number Diff line
@@ -5,6 +5,7 @@ 
#define __HCLGE_CMD_H

#include <linux/types.h>

#include <linux/io.h>

#include <linux/etherdevice.h>



#define HCLGE_CMDQ_TX_TIMEOUT		30000
@@ -712,8 +713,7 @@ struct hclge_mac_mgr_tbl_entry_cmd { 
	u8      flags;

	u8      resp_code;

	__le16  vlan_tag;

	__le32  mac_addr_hi32;

	__le16  mac_addr_lo16;

	u8      mac_addr[ETH_ALEN];

	__le16  rsv1;

	__le16  ethter_type;

	__le16  egress_port;

drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c

+1 −2
Original line number Diff line number Diff line
@@ -325,8 +325,7 @@ static const struct hclge_mac_mgr_tbl_entry_cmd hclge_mgr_table[] = { 
	{

		.flags = HCLGE_MAC_MGR_MASK_VLAN_B,

		.ethter_type = cpu_to_le16(ETH_P_LLDP),

		.mac_addr_hi32 = cpu_to_le32(htonl(0x0180C200)),

		.mac_addr_lo16 = cpu_to_le16(htons(0x000E)),

		.mac_addr = {0x01, 0x80, 0xc2, 0x00, 0x00, 0x0e},

		.i_port_bitmap = 0x1,

	},

};