Commit 0dfc1f4c authored by Zhihao Cheng's avatar Zhihao Cheng Committed by Mike Snitzer
Browse files

dm bufio: Fix missing decrement of no_sleep_enabled if dm_bufio_client_create failed 



The 'no_sleep_enabled' should be decreased in error handling path
in dm_bufio_client_create() when the DM_BUFIO_CLIENT_NO_SLEEP flag
is set, otherwise static_branch_unlikely() will always return true
even if no dm_bufio_client instances have DM_BUFIO_CLIENT_NO_SLEEP
flag set.

Cc: stable@vger.kernel.org
Fixes: 3c1c875d ("dm bufio: conditionally enable branching for DM_BUFIO_CLIENT_NO_SLEEP")
Signed-off-by: default avatarZhihao Cheng <chengzhihao1@huawei.com>
Signed-off-by: default avatarMike Snitzer <snitzer@kernel.org>
parent 4fe1ec99

drivers/md/dm-bufio.c

+2 −0
Original line number Diff line number Diff line
@@ -1858,6 +1858,8 @@ struct dm_bufio_client *dm_bufio_client_create(struct block_device *bdev, unsign 
	dm_io_client_destroy(c->dm_io);

bad_dm_io:

	mutex_destroy(&c->lock);

	if (c->no_sleep)

		static_branch_dec(&no_sleep_enabled);

	kfree(c);

bad_client:

	return ERR_PTR(r);