Commit 0ddc95b5 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Helge Deller
Browse files

fbdev: xilinxfb: Convert to platform remove callback returning void 



The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: default avatarHelge Deller <deller@gmx.de>
parent 89c4bbd4

drivers/video/fbdev/xilinxfb.c

+2 −4
Original line number Diff line number Diff line
@@ -474,11 +474,9 @@ static int xilinxfb_of_probe(struct platform_device *pdev) 
	return xilinxfb_assign(pdev, drvdata, &pdata);

}



static int xilinxfb_of_remove(struct platform_device *op)

static void xilinxfb_of_remove(struct platform_device *op)

{

	xilinxfb_release(&op->dev);



	return 0;

}



/* Match table for of_platform binding */
@@ -494,7 +492,7 @@ MODULE_DEVICE_TABLE(of, xilinxfb_of_match); 


static struct platform_driver xilinxfb_of_driver = {

	.probe = xilinxfb_of_probe,

	.remove = xilinxfb_of_remove,

	.remove_new = xilinxfb_of_remove,

	.driver = {

		.name = DRIVER_NAME,

		.of_match_table = xilinxfb_of_match,