Commit 0dd0bbc2 authored by Sven Schnelle's avatar Sven Schnelle Committed by Alexander Gordeev
Browse files

s390/vdso: check for undefined symbols after build 



When adding an undefined symbol the build still succeeds, but
userspace is crashing trying to execute vdso because the
undefined symbol is not resolved. Add the check for undefined
symbols to prevent this.

Signed-off-by: default avatarSven Schnelle <svens@linux.ibm.com>
Acked-by: default avatarHeiko Carstens <hca@linux.ibm.com>
Signed-off-by: default avatarAlexander Gordeev <agordeev@linux.ibm.com>
parent 51f513fd

arch/s390/kernel/vdso32/Makefile

+4 −1
Original line number Diff line number Diff line
@@ -40,8 +40,11 @@ KCSAN_SANITIZE := n 
# Force dependency (incbin is bad)

$(obj)/vdso32_wrapper.o : $(obj)/vdso32.so



quiet_cmd_vdso_and_check = VDSO    $@

      cmd_vdso_and_check = $(cmd_ld); $(cmd_vdso_check)



$(obj)/vdso32.so.dbg: $(src)/vdso32.lds $(obj-vdso32) FORCE

	$(call if_changed,ld)

	$(call if_changed,vdso_and_check)



# strip rule for the .so file

$(obj)/%.so: OBJCOPYFLAGS := -S

arch/s390/kernel/vdso64/Makefile

+4 −1
Original line number Diff line number Diff line
@@ -44,9 +44,12 @@ KCSAN_SANITIZE := n 
# Force dependency (incbin is bad)

$(obj)/vdso64_wrapper.o : $(obj)/vdso64.so



quiet_cmd_vdso_and_check = VDSO    $@

      cmd_vdso_and_check = $(cmd_ld); $(cmd_vdso_check)



# link rule for the .so file, .lds has to be first

$(obj)/vdso64.so.dbg: $(src)/vdso64.lds $(obj-vdso64) $(obj-cvdso64) FORCE

	$(call if_changed,ld)

	$(call if_changed,vdso_and_check)



# strip rule for the .so file

$(obj)/%.so: OBJCOPYFLAGS := -S