Commit 0dbaf0fa authored by GUO Zihua's avatar GUO Zihua Committed by Jakub Kicinski
Browse files

net: xscale: Fix return type for implementation of ndo_start_xmit 



Since Linux now supports CFI, it will be a good idea to fix mismatched
return type for implementation of hooks. Otherwise this might get
cought out by CFI and cause a panic.

eth_xmit() would return either NETDEV_TX_BUSY or NETDEV_TX_OK, so
change the return type to netdev_tx_t directly.

Signed-off-by: default avatarGUO Zihua <guozihua@huawei.com>
Link: https://lore.kernel.org/r/20220902081612.60405-1-guozihua@huawei.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 12f7bd25

drivers/net/ethernet/xscale/ixp4xx_eth.c

+1 −1
Original line number Diff line number Diff line
@@ -841,7 +841,7 @@ static void eth_txdone_irq(void *unused) 
	}

}



static int eth_xmit(struct sk_buff *skb, struct net_device *dev)

static netdev_tx_t eth_xmit(struct sk_buff *skb, struct net_device *dev)

{

	struct port *port = netdev_priv(dev);

	unsigned int txreadyq = port->plat->txreadyq;