Commit 0db23276 authored Jul 13, 2022 by Kuniyuki Iwashima Committed by David S. Miller Jul 15, 2022

ip: Fix a data-race around sysctl_ip_autobind_reuse.

While reading sysctl_ip_autobind_reuse, it can be changed concurrently.
Thus, we need to add READ_ONCE() to its reader.

Fixes: 4b01a967 ("tcp: bind(0) remove the SO_REUSEADDR restriction when ephemeral ports are exhausted.")
Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 289d3b21

net/ipv4/inet_connection_sock.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -263,7 +263,7 @@ inet_csk_find_open_port(struct sock sk, struct inet_bind_bucket tb_ret, int
		goto other_half_scan;
		}

		if (net->ipv4.sysctl_ip_autobind_reuse && !relax) {
		if (READ_ONCE(net->ipv4.sysctl_ip_autobind_reuse) && !relax) {
		/* We still have a chance to connect to different destinations */
		relax = true;
		goto ports_exhausted;