Unverified Commit 0d7f2459 authored by Sathyanarayana Nujella's avatar Sathyanarayana Nujella Committed by Mark Brown
Browse files

ASoC: Intel: Boards: tgl_max98373: update TDM slot_width 



Speaker amp's SSP bclk configuration was changed in the topology file to be
based on 12.288MHz and dai_ops->hw_params is based on s32le format.
But, the TDM slot size remained set to 24 bits.
This inconsistency created audible noises and needs to be corrected.
This patch updates TDM slot width to 32.

Fixes: bc7477fc ("ASoC: Intel: Boards: tgl_max98373: Update TDM configuration in hw_params")

Signed-off-by: default avatarSathyanarayana Nujella <sathyanarayana.nujella@intel.com>
Reviewed-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Signed-off-by: default avatarRanjani Sridharan <ranjani.sridharan@linux.intel.com>
Link: https://lore.kernel.org/r/20201201211150.433472-1-ranjani.sridharan@linux.intel.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent f9d8ae0b

sound/soc/intel/boards/sof_maxim_common.c

+2 −2
Original line number Diff line number Diff line
@@ -49,11 +49,11 @@ static int max98373_hw_params(struct snd_pcm_substream *substream, 
	for_each_rtd_codec_dais(rtd, j, codec_dai) {

		if (!strcmp(codec_dai->component->name, MAX_98373_DEV0_NAME)) {

			/* DEV0 tdm slot configuration */

			snd_soc_dai_set_tdm_slot(codec_dai, 0x03, 3, 8, 24);

			snd_soc_dai_set_tdm_slot(codec_dai, 0x03, 3, 8, 32);

		}

		if (!strcmp(codec_dai->component->name, MAX_98373_DEV1_NAME)) {

			/* DEV1 tdm slot configuration */

			snd_soc_dai_set_tdm_slot(codec_dai, 0x0C, 3, 8, 24);

			snd_soc_dai_set_tdm_slot(codec_dai, 0x0C, 3, 8, 32);

		}

	}

	return 0;