Commit 0d65f746 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Stephen Boyd
Browse files

clk: stm32: Convert to platform remove callback returning void 



The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230312161512.2715500-26-u.kleine-koenig@pengutronix.de


Signed-off-by: default avatarStephen Boyd <sboyd@kernel.org>
parent d9f139da

drivers/clk/stm32/clk-stm32mp13.c

+2 −4
Original line number Diff line number Diff line
@@ -1593,15 +1593,13 @@ static int stm32mp1_rcc_clocks_probe(struct platform_device *pdev) 
	return ret;

}



static int stm32mp1_rcc_clocks_remove(struct platform_device *pdev)

static void stm32mp1_rcc_clocks_remove(struct platform_device *pdev)

{

	struct device *dev = &pdev->dev;

	struct device_node *child, *np = dev_of_node(dev);



	for_each_available_child_of_node(np, child)

		of_clk_del_provider(child);



	return 0;

}



static struct platform_driver stm32mp13_rcc_clocks_driver = {
@@ -1610,7 +1608,7 @@ static struct platform_driver stm32mp13_rcc_clocks_driver = { 
		.of_match_table = stm32mp13_match_data,

	},

	.probe = stm32mp1_rcc_clocks_probe,

	.remove = stm32mp1_rcc_clocks_remove,

	.remove_new = stm32mp1_rcc_clocks_remove,

};



static int __init stm32mp13_clocks_init(void)