Commit 0d625446 authored by Christoph Hellwig's avatar Christoph Hellwig Committed by Andrew Morton
Browse files

backing_dev: remove current->backing_dev_info 

Patch series "cleanup the filemap / direct I/O interaction", v4.

This series cleans up some of the generic write helper calling conventions
and the page cache writeback / invalidation for direct I/O.  This is a
spinoff from the no-bufferhead kernel project, for which we'll want to an
use iomap based buffered write path in the block layer.


This patch (of 12):

The last user of current->backing_dev_info disappeared in commit
b9b1335e ("remove bdi_congested() and wb_congested() and related
functions").  Remove the field and all assignments to it.

Link: https://lkml.kernel.org/r/20230601145904.1385409-1-hch@lst.de
Link: https://lkml.kernel.org/r/20230601145904.1385409-2-hch@lst.de


Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Reviewed-by: default avatarChristian Brauner <brauner@kernel.org>
Reviewed-by: default avatarDamien Le Moal <dlemoal@kernel.org>
Reviewed-by: default avatarHannes Reinecke <hare@suse.de>
Reviewed-by: default avatarJohannes Thumshirn <johannes.thumshirn@wdc.com>
Reviewed-by: default avatarDarrick J. Wong <djwong@kernel.org>
Acked-by: default avatarTheodore Ts'o <tytso@mit.edu>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Andreas Gruenbacher <agruenba@redhat.com>
Cc: Anna Schumaker <anna@kernel.org>
Cc: Chao Yu <chao@kernel.org>
Cc: Ilya Dryomov <idryomov@gmail.com>
Cc: Jaegeuk Kim <jaegeuk@kernel.org>
Cc: Jens Axboe <axboe@kernel.dk>
Cc: Matthew Wilcox <willy@infradead.org>
Cc: Miklos Szeredi <miklos@szeredi.hu>
Cc: Miklos Szeredi <mszeredi@redhat.com>
Cc: Trond Myklebust <trond.myklebust@hammerspace.com>
Cc: Xiubo Li <xiubli@redhat.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent e0228d59

fs/btrfs/file.c

+1 −5
Original line number Diff line number Diff line
@@ -1145,7 +1145,6 @@ static int btrfs_write_check(struct kiocb *iocb, struct iov_iter *from, 
	    !(BTRFS_I(inode)->flags & (BTRFS_INODE_NODATACOW | BTRFS_INODE_PREALLOC)))

		return -EAGAIN;



	current->backing_dev_info = inode_to_bdi(inode);

	ret = file_remove_privs(file);

	if (ret)

		return ret;
@@ -1165,11 +1164,9 @@ static int btrfs_write_check(struct kiocb *iocb, struct iov_iter *from, 
		loff_t end_pos = round_up(pos + count, fs_info->sectorsize);



		ret = btrfs_cont_expand(BTRFS_I(inode), oldsize, end_pos);

		if (ret) {

			current->backing_dev_info = NULL;

		if (ret)

			return ret;

	}

	}



	return 0;

}
@@ -1689,7 +1686,6 @@ ssize_t btrfs_do_write_iter(struct kiocb *iocb, struct iov_iter *from, 
	if (sync)

		atomic_dec(&inode->sync_writers);



	current->backing_dev_info = NULL;

	return num_written;

}

fs/ceph/file.c

+0 −4
Original line number Diff line number Diff line
@@ -1791,9 +1791,6 @@ static ssize_t ceph_write_iter(struct kiocb *iocb, struct iov_iter *from) 
	else

		ceph_start_io_write(inode);



	/* We can write back this queue in page reclaim */

	current->backing_dev_info = inode_to_bdi(inode);



	if (iocb->ki_flags & IOCB_APPEND) {

		err = ceph_do_getattr(inode, CEPH_STAT_CAP_SIZE, false);

		if (err < 0)
@@ -1940,7 +1937,6 @@ static ssize_t ceph_write_iter(struct kiocb *iocb, struct iov_iter *from) 
		ceph_end_io_write(inode);

out_unlocked:

	ceph_free_cap_flush(prealloc_cf);

	current->backing_dev_info = NULL;

	return written ? written : err;

}

fs/ext4/file.c

+0 −2
Original line number Diff line number Diff line
@@ -285,9 +285,7 @@ static ssize_t ext4_buffered_write_iter(struct kiocb *iocb, 
	if (ret <= 0)

		goto out;



	current->backing_dev_info = inode_to_bdi(inode);

	ret = generic_perform_write(iocb, from);

	current->backing_dev_info = NULL;



out:

	inode_unlock(inode);

fs/f2fs/file.c

+0 −2
Original line number Diff line number Diff line
@@ -4517,9 +4517,7 @@ static ssize_t f2fs_buffered_write_iter(struct kiocb *iocb, 
	if (iocb->ki_flags & IOCB_NOWAIT)

		return -EOPNOTSUPP;



	current->backing_dev_info = inode_to_bdi(inode);

	ret = generic_perform_write(iocb, from);

	current->backing_dev_info = NULL;



	if (ret > 0) {

		iocb->ki_pos += ret;

fs/fuse/file.c

+0 −4
Original line number Diff line number Diff line
@@ -1362,9 +1362,6 @@ static ssize_t fuse_cache_write_iter(struct kiocb *iocb, struct iov_iter *from) 
writethrough:

	inode_lock(inode);



	/* We can write back this queue in page reclaim */

	current->backing_dev_info = inode_to_bdi(inode);



	err = generic_write_checks(iocb, from);

	if (err <= 0)

		goto out;
@@ -1409,7 +1406,6 @@ static ssize_t fuse_cache_write_iter(struct kiocb *iocb, struct iov_iter *from) 
			iocb->ki_pos += written;

	}

out:

	current->backing_dev_info = NULL;

	inode_unlock(inode);

	if (written > 0)

		written = generic_write_sync(iocb, written);