Commit 0d5e8172 authored by Damien Le Moal's avatar Damien Le Moal
Browse files

ata: pata_parport: Fix fit2 module code indentation and style 



Fix the header, indentation and coding style in the fit2 pata parport
protocol module to suppress warnings from smatch and other static code
analyzers.

No functional changes.

Signed-off-by: default avatarDamien Le Moal <dlemoal@kernel.org>
parent 8be31971

drivers/ata/pata_parport/fit2.c

+64 −67
Original line number Diff line number Diff line 
// SPDX-License-Identifier: GPL-2.0-or-later

/*

        fit2.c        (c) 1998  Grant R. Guenther <grant@torque.net>

                          Under the terms of the GNU General Public License.



	fit2.c is a low-level protocol driver for the older version

        of the Fidelity International Technology parallel port adapter.  

	This adapter is used in their TransDisk 2000 and older TransDisk

	3000 portable hard-drives.  As far as I can tell, this device

	supports 4-bit mode _only_.  



	Newer models of the FIT products use an enhanced protocol.

	The "fit3" protocol module should support current drives.



 * (c) 1998  Grant R. Guenther <grant@torque.net>

 *

 * fit2.c is a low-level protocol driver for the older version

 * of the Fidelity International Technology parallel port adapter.

 * This adapter is used in their TransDisk 2000 and older TransDisk

 * 3000 portable hard-drives.  As far as I can tell, this device

 * supports 4-bit mode _only_.

 *

 * Newer models of the FIT products use an enhanced protocol.

 * The "fit3" protocol module should support current drives.

 */



#include <linux/module.h>
@@ -24,30 +23,34 @@ 


#define j44(a, b)	(((a >> 4) & 0x0f) | (b & 0xf0))



/* cont = 0 - access the IDE register file 

   cont = 1 - access the IDE command set 



NB:  The FIT adapter does not appear to use the control registers.

So, we map ALT_STATUS to STATUS and NO-OP writes to the device

control register - this means that IDE reset will not work on these

devices.



/*

 * cont = 0 - access the IDE register file

 * cont = 1 - access the IDE command set

 *

 * NB: The FIT adapter does not appear to use the control registers.

 * So, we map ALT_STATUS to STATUS and NO-OP writes to the device

 * control register - this means that IDE reset will not work on these

 * devices.

 */



static void fit2_write_regr(struct pi_adapter *pi, int cont, int regr, int val)



{	if (cont == 1) return;

{

	if (cont == 1)

		return;

	w2(0xc); w0(regr); w2(4); w0(val); w2(5); w0(0); w2(4);

}



static int fit2_read_regr(struct pi_adapter *pi, int cont, int regr)



{	int  a, b, r;

{

	int  a, b, r;



	if (cont) {

	  if (regr != 6) return 0xff;

		if (regr != 6)

			return 0xff;

		r = 7;

	} else r = regr + 0x10;

	} else {

		r = regr + 0x10;

	}



	w2(0xc); w0(r); w2(4); w2(5);

	w0(0); a = r1();
@@ -55,17 +58,15 @@ static int fit2_read_regr(struct pi_adapter *pi, int cont, int regr) 
	w2(4);



	return j44(a, b);



}



static void fit2_read_block(struct pi_adapter *pi, char *buf, int count)



{	int  k, a, b, c, d;

{

	int  k, a, b, c, d;



	w2(0xc); w0(0x10);



	for (k = 0; k < count / 4; k++) {



		w2(4); w2(5);

		w0(0); a = r1(); w0(1); b = r1();

		w0(3); c = r1(); w0(2); d = r1();
@@ -77,17 +78,14 @@ static void fit2_read_block(struct pi_adapter *pi, char *buf, int count) 
		w0(1); c = r1(); w0(0); d = r1();

		buf[4 * k + 2] = j44(d, c);

		buf[4 * k + 3] = j44(a, b);



	}



	w2(4);



}



static void fit2_write_block(struct pi_adapter *pi, char *buf, int count)



{	int k;



{

	int k;



	w2(0xc); w0(0);

	for (k = 0; k < count / 2; k++) {
@@ -98,20 +96,19 @@ static void fit2_write_block(struct pi_adapter *pi, char *buf, int count) 
}



static void fit2_connect(struct pi_adapter *pi)



{       pi->saved_r0 = r0();

{

	pi->saved_r0 = r0();

	pi->saved_r2 = r2();

	w2(0xcc);

}



static void fit2_disconnect(struct pi_adapter *pi)



{       w0(pi->saved_r0);

{

	w0(pi->saved_r0);

	w2(pi->saved_r2);

}



static void fit2_log_adapter(struct pi_adapter *pi)



{

	dev_info(&pi->dev, "FIT 2000 adapter at 0x%x, delay %d\n",

		 pi->port, pi->delay);