Commit 0d5e743d authored by Kees Cook's avatar Kees Cook Committed by Kalle Valo
Browse files

rtlwifi: rtl8192de: Fully initialize curvecount_val 



In preparation for FORTIFY_SOURCE performing compile-time and run-time
field bounds checking for memcpy(), memmove(), and memset(), avoid
intentionally writing across neighboring array fields.

The size argument to memset() is bytes, but the array element size
of curvecount_val is u32, so "CV_CURVE_CNT * 2" was only 1/4th of the
contents of curvecount_val. Adjust memset() to wipe full buffer size.

Signed-off-by: default avatarKees Cook <keescook@chromium.org>
Reviewed-by: default avatarLarry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20210617171317.3410722-1-keescook@chromium.org
parent 3f26f766

drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c

+1 −1
Original line number Diff line number Diff line
@@ -2574,7 +2574,7 @@ static void _rtl92d_phy_lc_calibrate_sw(struct ieee80211_hw *hw, bool is2t) 
			RTPRINT(rtlpriv, FINIT, INIT_IQK,

				"path-B / 2.4G LCK\n");

		}

		memset(&curvecount_val[0], 0, CV_CURVE_CNT * 2);

		memset(curvecount_val, 0, sizeof(curvecount_val));

		/* Set LC calibration off */

		rtl_set_rfreg(hw, (enum radio_path)index, RF_CHNLBW,

			      0x08000, 0x0);