Unverified Commit 0d56a451 authored by Christian Brauner's avatar Christian Brauner
Browse files

stat: handle idmapped mounts 

The generic_fillattr() helper fills in the basic attributes associated
with an inode. Enable it to handle idmapped mounts. If the inode is
accessed through an idmapped mount map it into the mount's user
namespace before we store the uid and gid. If the initial user namespace
is passed nothing changes so non-idmapped mounts will see identical
behavior as before.

Link: https://lore.kernel.org/r/20210121131959.646623-12-christian.brauner@ubuntu.com


Cc: Christoph Hellwig <hch@lst.de>
Cc: David Howells <dhowells@redhat.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: linux-fsdevel@vger.kernel.org
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Reviewed-by: default avatarJames Morris <jamorris@linux.microsoft.com>
Signed-off-by: default avatarChristian Brauner <christian.brauner@ubuntu.com>
parent 71bc356f

fs/9p/vfs_inode.c

+2 −2
Original line number Diff line number Diff line
@@ -1027,7 +1027,7 @@ v9fs_vfs_getattr(const struct path *path, struct kstat *stat, 
	p9_debug(P9_DEBUG_VFS, "dentry: %p\n", dentry);

	v9ses = v9fs_dentry2v9ses(dentry);

	if (v9ses->cache == CACHE_LOOSE || v9ses->cache == CACHE_FSCACHE) {

		generic_fillattr(d_inode(dentry), stat);

		generic_fillattr(&init_user_ns, d_inode(dentry), stat);

		return 0;

	}

	fid = v9fs_fid_lookup(dentry);
@@ -1040,7 +1040,7 @@ v9fs_vfs_getattr(const struct path *path, struct kstat *stat, 
		return PTR_ERR(st);



	v9fs_stat2inode(st, d_inode(dentry), dentry->d_sb, 0);

	generic_fillattr(d_inode(dentry), stat);

	generic_fillattr(&init_user_ns, d_inode(dentry), stat);



	p9stat_free(st);

	kfree(st);

fs/9p/vfs_inode_dotl.c

+2 −2
Original line number Diff line number Diff line
@@ -468,7 +468,7 @@ v9fs_vfs_getattr_dotl(const struct path *path, struct kstat *stat, 
	p9_debug(P9_DEBUG_VFS, "dentry: %p\n", dentry);

	v9ses = v9fs_dentry2v9ses(dentry);

	if (v9ses->cache == CACHE_LOOSE || v9ses->cache == CACHE_FSCACHE) {

		generic_fillattr(d_inode(dentry), stat);

		generic_fillattr(&init_user_ns, d_inode(dentry), stat);

		return 0;

	}

	fid = v9fs_fid_lookup(dentry);
@@ -485,7 +485,7 @@ v9fs_vfs_getattr_dotl(const struct path *path, struct kstat *stat, 
		return PTR_ERR(st);



	v9fs_stat2inode_dotl(st, d_inode(dentry), 0);

	generic_fillattr(d_inode(dentry), stat);

	generic_fillattr(&init_user_ns, d_inode(dentry), stat);

	/* Change block size to what the server returned */

	stat->blksize = st->st_blksize;

fs/afs/inode.c

+1 −1
Original line number Diff line number Diff line
@@ -745,7 +745,7 @@ int afs_getattr(const struct path *path, struct kstat *stat, 


	do {

		read_seqbegin_or_lock(&vnode->cb_lock, &seq);

		generic_fillattr(inode, stat);

		generic_fillattr(&init_user_ns, inode, stat);

		if (test_bit(AFS_VNODE_SILLY_DELETED, &vnode->flags) &&

		    stat->nlink > 0)

			stat->nlink -= 1;

fs/btrfs/inode.c

+1 −1
Original line number Diff line number Diff line
@@ -8842,7 +8842,7 @@ static int btrfs_getattr(const struct path *path, struct kstat *stat, 
				  STATX_ATTR_IMMUTABLE |

				  STATX_ATTR_NODUMP);



	generic_fillattr(inode, stat);

	generic_fillattr(&init_user_ns, inode, stat);

	stat->dev = BTRFS_I(inode)->root->anon_dev;



	spin_lock(&BTRFS_I(inode)->lock);

fs/ceph/inode.c

+1 −1
Original line number Diff line number Diff line
@@ -2385,7 +2385,7 @@ int ceph_getattr(const struct path *path, struct kstat *stat, 
			return err;

	}



	generic_fillattr(inode, stat);

	generic_fillattr(&init_user_ns, inode, stat);

	stat->ino = ceph_present_inode(inode);



	/*