Commit 0d0f034d authored by David S. Miller's avatar David S. Miller
Browse files

Merge branch 'j7200-support' 

Siddharth Vadapalli says:

====================
J7200: CPSW5G: Add support for QSGMII mode to am65-cpsw driver

Add support for QSGMII mode to am65-cpsw driver.

Change log:

v4-> v5:
1. Move ti,j7200-cpswxg-nuss compatible to the line above the
   ti,j721e-cpsw-nuss compatible.
2. Add allOf and move if-then statements within it to allow future if-then
   statements to be added easily.

v3 -> v4:
1. Update bindings to disallow ports based on compatible, instead of
   adding a new if/then statement for the new compatible.
2. Add Else-If condition for RMII mode in the set of supported interfaces.
   Support for RMII mode is already present in the driver and I had
   missed out adding a condition for RMII mode in the previous patches.

v2 -> v3:
1. In ti,k3-am654-cpsw-nuss.yaml, restrict if/then statement to port
   nodes.

v1 -> v2:
1. Add new compatible for CPSW5G in ti,k3-am654-cpsw-nuss.yaml and extend
   properties for new compatible.
2. Add extra_modes member to struct am65_cpsw_pdata to be used for QSGMII
   mode by new compatible.
3. Add check for phylink supported modes to ensure that only one phy mode
   is advertised as supported.
4. Check if extra_modes supports QSGMII mode in am65_cpsw_nuss_mac_config()
   for register write.
5. Add check for assigning port->sgmii_base only when extra_modes is valid.

v4: https://lore.kernel.org/r/20220816060139.111934-1-s-vadapalli@ti.com/
v3: https://lore.kernel.org/r/20220606110443.30362-1-s-vadapalli@ti.com/
v2: https://lore.kernel.org/r/20220602114558.6204-1-s-vadapalli@ti.com/
v1: https://lore.kernel.org/r/20220531113058.23708-1-s-vadapalli@ti.com/


====================

Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parents c205cc75 763015a7

Documentation/devicetree/bindings/net/ti,k3-am654-cpsw-nuss.yaml

+16 −2
Original line number Diff line number Diff line
@@ -55,6 +55,7 @@ properties: 
  compatible:

    enum:

      - ti,am654-cpsw-nuss

      - ti,j7200-cpswxg-nuss

      - ti,j721e-cpsw-nuss

      - ti,am642-cpsw-nuss
@@ -110,7 +111,7 @@ properties: 
        const: 0



    patternProperties:

      port@[1-2]:

      "^port@[1-4]$":

        type: object

        description: CPSWxG NUSS external ports
@@ -119,7 +120,7 @@ properties: 
        properties:

          reg:

            minimum: 1

            maximum: 2

            maximum: 4

            description: CPSW port number



          phys:
@@ -178,6 +179,19 @@ required: 
  - '#address-cells'

  - '#size-cells'



allOf:

  - if:

      not:

        properties:

          compatible:

            contains:

              const: ti,j7200-cpswxg-nuss

    then:

      properties:

        ethernet-ports:

          patternProperties:

            "^port@[3-4]$": false



additionalProperties: false



examples:

drivers/net/ethernet/ti/am65-cpsw-nuss.c

+37 −7
Original line number Diff line number Diff line
@@ -74,6 +74,9 @@ 
#define AM65_CPSW_PORTN_REG_TS_VLAN_LTYPE_REG	0x318

#define AM65_CPSW_PORTN_REG_TS_CTL_LTYPE2       0x31C



#define AM65_CPSW_SGMII_CONTROL_REG		0x010

#define AM65_CPSW_SGMII_CONTROL_MR_AN_ENABLE	BIT(0)



#define AM65_CPSW_CTL_VLAN_AWARE		BIT(1)

#define AM65_CPSW_CTL_P0_ENABLE			BIT(2)

#define AM65_CPSW_CTL_P0_TX_CRC_REMOVE		BIT(13)
@@ -590,11 +593,6 @@ static int am65_cpsw_nuss_ndo_slave_open(struct net_device *ndev) 
	/* mac_sl should be configured via phy-link interface */

	am65_cpsw_sl_ctl_reset(port);



	ret = phy_set_mode_ext(port->slave.ifphy, PHY_MODE_ETHERNET,

			       port->slave.phy_if);

	if (ret)

		goto error_cleanup;



	ret = phylink_of_phy_connect(port->slave.phylink, port->slave.phy_node, 0);

	if (ret)

		goto error_cleanup;
@@ -1409,7 +1407,14 @@ static const struct net_device_ops am65_cpsw_nuss_netdev_ops = { 
static void am65_cpsw_nuss_mac_config(struct phylink_config *config, unsigned int mode,

				      const struct phylink_link_state *state)

{

	/* Currently not used */

	struct am65_cpsw_slave_data *slave = container_of(config, struct am65_cpsw_slave_data,

							  phylink_config);

	struct am65_cpsw_port *port = container_of(slave, struct am65_cpsw_port, slave);

	struct am65_cpsw_common *common = port->common;



	if (common->pdata.extra_modes & BIT(state->interface))

		writel(AM65_CPSW_SGMII_CONTROL_MR_AN_ENABLE,

		       port->sgmii_base + AM65_CPSW_SGMII_CONTROL_REG);

}



static void am65_cpsw_nuss_mac_link_down(struct phylink_config *config, unsigned int mode,
@@ -1847,6 +1852,8 @@ static int am65_cpsw_nuss_init_slave_ports(struct am65_cpsw_common *common) 
		port->common = common;

		port->port_base = common->cpsw_base + AM65_CPSW_NU_PORTS_BASE +

				  AM65_CPSW_NU_PORTS_OFFSET * (port_id);

		if (common->pdata.extra_modes)

			port->sgmii_base = common->ss_base + AM65_CPSW_SGMII_BASE * (port_id);

		port->stat_base = common->cpsw_base + AM65_CPSW_NU_STATS_BASE +

				  (AM65_CPSW_NU_STATS_PORT_OFFSET * port_id);

		port->name = of_get_property(port_np, "label", NULL);
@@ -1886,6 +1893,10 @@ static int am65_cpsw_nuss_init_slave_ports(struct am65_cpsw_common *common) 
			goto of_node_put;

		}



		ret = phy_set_mode_ext(port->slave.ifphy, PHY_MODE_ETHERNET, port->slave.phy_if);

		if (ret)

			goto of_node_put;



		ret = of_get_mac_address(port_np, port->slave.mac_addr);

		if (ret) {

			am65_cpsw_am654_get_efuse_macid(port_np,
@@ -1981,7 +1992,18 @@ am65_cpsw_nuss_init_port_ndev(struct am65_cpsw_common *common, u32 port_idx) 
	port->slave.phylink_config.type = PHYLINK_NETDEV;

	port->slave.phylink_config.mac_capabilities = MAC_SYM_PAUSE | MAC_10 | MAC_100 | MAC_1000FD;



	if (phy_interface_mode_is_rgmii(port->slave.phy_if)) {

		phy_interface_set_rgmii(port->slave.phylink_config.supported_interfaces);

	} else if (port->slave.phy_if == PHY_INTERFACE_MODE_RMII) {

		__set_bit(PHY_INTERFACE_MODE_RMII,

			  port->slave.phylink_config.supported_interfaces);

	} else if (common->pdata.extra_modes & BIT(port->slave.phy_if)) {

		__set_bit(PHY_INTERFACE_MODE_QSGMII,

			  port->slave.phylink_config.supported_interfaces);

	} else {

		dev_err(dev, "selected phy-mode is not supported\n");

		return -EOPNOTSUPP;

	}



	phylink = phylink_create(&port->slave.phylink_config,

				 of_node_to_fwnode(port->slave.phy_node),
@@ -2611,10 +2633,18 @@ static const struct am65_cpsw_pdata am64x_cpswxg_pdata = { 
	.fdqring_mode = K3_RINGACC_RING_MODE_RING,

};



static const struct am65_cpsw_pdata j7200_cpswxg_pdata = {

	.quirks = 0,

	.ale_dev_id = "am64-cpswxg",

	.fdqring_mode = K3_RINGACC_RING_MODE_RING,

	.extra_modes = BIT(PHY_INTERFACE_MODE_QSGMII),

};



static const struct of_device_id am65_cpsw_nuss_of_mtable[] = {

	{ .compatible = "ti,am654-cpsw-nuss", .data = &am65x_sr1_0},

	{ .compatible = "ti,j721e-cpsw-nuss", .data = &j721e_pdata},

	{ .compatible = "ti,am642-cpsw-nuss", .data = &am64x_cpswxg_pdata},

	{ .compatible = "ti,j7200-cpswxg-nuss", .data = &j7200_cpswxg_pdata},

	{ /* sentinel */ },

};

MODULE_DEVICE_TABLE(of, am65_cpsw_nuss_of_mtable);

drivers/net/ethernet/ti/am65-cpsw-nuss.h

+2 −0
Original line number Diff line number Diff line
@@ -46,6 +46,7 @@ struct am65_cpsw_port { 
	const char			*name;

	u32				port_id;

	void __iomem			*port_base;

	void __iomem			*sgmii_base;

	void __iomem			*stat_base;

	void __iomem			*fetch_ram_base;

	bool				disabled;
@@ -88,6 +89,7 @@ struct am65_cpsw_rx_chn { 


struct am65_cpsw_pdata {

	u32	quirks;

	u64	extra_modes;

	enum k3_ring_mode fdqring_mode;

	const char	*ale_dev_id;

};