Commit 0cf8d292 authored by Simon Ser's avatar Simon Ser
Browse files

drm/sysfs: rename drm_sysfs_connector_status_event() 



Rename drm_sysfs_connector_status_event() to
drm_sysfs_connector_property_event(). Indeed, "status" is a bit
vague: it can easily be confused with the connected/disconnected
status of the connector. This function has nothing to do with
connected/disconnected: it merely sends a notification that a
connector's property has changed (e.g. HDCP, privacy screen, etc).

Signed-off-by: default avatarSimon Ser <contact@emersion.fr>
Cc: Manasi Navare <navaremanasi@chromium.org>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Harry Wentland <harry.wentland@amd.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Reviewed-by: default avatarSam Ravnborg <sam@ravnborg.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20230620174231.260335-1-contact@emersion.fr
parent 3fe630c7

drivers/gpu/drm/display/drm_hdcp_helper.c

+2 −2
Original line number Diff line number Diff line
@@ -415,7 +415,7 @@ void drm_hdcp_update_content_protection(struct drm_connector *connector, 
		return;



	state->content_protection = val;

	drm_sysfs_connector_status_event(connector,

	drm_sysfs_connector_property_event(connector,

					   dev->mode_config.content_protection_property);

}

EXPORT_SYMBOL(drm_hdcp_update_content_protection);

drivers/gpu/drm/drm_connector.c

+4 −4
Original line number Diff line number Diff line
@@ -2730,9 +2730,9 @@ static int drm_connector_privacy_screen_notifier( 
	drm_connector_update_privacy_screen_properties(connector, true);

	drm_modeset_unlock(&dev->mode_config.connection_mutex);



	drm_sysfs_connector_status_event(connector,

	drm_sysfs_connector_property_event(connector,

					   connector->privacy_screen_sw_state_property);

	drm_sysfs_connector_status_event(connector,

	drm_sysfs_connector_property_event(connector,

					   connector->privacy_screen_hw_state_property);



	return NOTIFY_DONE;

drivers/gpu/drm/drm_sysfs.c

+13 −10
Original line number Diff line number Diff line
@@ -487,16 +487,16 @@ void drm_sysfs_connector_hotplug_event(struct drm_connector *connector) 
EXPORT_SYMBOL(drm_sysfs_connector_hotplug_event);



/**

 * drm_sysfs_connector_status_event - generate a DRM uevent for connector

 * property status change

 * @connector: connector on which property status changed

 * @property: connector property whose status changed.

 * drm_sysfs_connector_property_event - generate a DRM uevent for connector

 * property change

 * @connector: connector on which property changed

 * @property: connector property which has changed.

 *

 * Send a uevent for the DRM device specified by @dev.  Currently we

 * Send a uevent for the specified DRM connector and property.  Currently we

 * set HOTPLUG=1 and connector id along with the attached property id

 * related to the status change.

 * related to the change.

 */

void drm_sysfs_connector_status_event(struct drm_connector *connector,

void drm_sysfs_connector_property_event(struct drm_connector *connector,

					struct drm_property *property)

{

	struct drm_device *dev = connector->dev;
@@ -511,11 +511,14 @@ void drm_sysfs_connector_status_event(struct drm_connector *connector, 
	snprintf(prop_id, ARRAY_SIZE(prop_id),

		 "PROPERTY=%u", property->base.id);



	DRM_DEBUG("generating connector status event\n");

	drm_dbg_kms(connector->dev,

		    "[CONNECTOR:%d:%s] generating connector property event for [PROP:%d:%s]\n",

		    connector->base.id, connector->name,

		    property->base.id, property->name);



	kobject_uevent_env(&dev->primary->kdev->kobj, KOBJ_CHANGE, envp);

}

EXPORT_SYMBOL(drm_sysfs_connector_status_event);

EXPORT_SYMBOL(drm_sysfs_connector_property_event);



struct device *drm_sysfs_minor_alloc(struct drm_minor *minor)

{

include/drm/drm_sysfs.h

+2 −2
Original line number Diff line number Diff line
@@ -12,6 +12,6 @@ void drm_class_device_unregister(struct device *dev); 


void drm_sysfs_hotplug_event(struct drm_device *dev);

void drm_sysfs_connector_hotplug_event(struct drm_connector *connector);

void drm_sysfs_connector_status_event(struct drm_connector *connector,

void drm_sysfs_connector_property_event(struct drm_connector *connector,

					struct drm_property *property);

#endif